Closed
Bug 350547
Opened 18 years ago
Closed 18 years ago
No checked icon for history toolbar button
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2
People
(Reporter: mwu, Assigned: Gavin)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
mconnor
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
The bookmarks toolbar button turns blue when you click on it, to indicate the sidebar is open. The history toolbar button does not. The icon does not exist in Toolbar.png either.
Reporter | ||
Updated•18 years ago
|
Flags: blocking-firefox2?
Version: Trunk → 2.0 Branch
Comment 1•18 years ago
|
||
On Mac, I'm also not seeing any hover state for the history toolbar icon.
Assignee: nobody → jgoldman
Flags: blocking-firefox2? → blocking-firefox2+
Updated•18 years ago
|
Whiteboard: [Fx2 theme change]
Comment 2•18 years ago
|
||
This all seems to be fixed now, please reopen if I misunderstood!
Assignee | ||
Comment 3•18 years ago
|
||
This isn't fixed, but it isn't a regression either - 1.5 also had this bug.
Status: RESOLVED → REOPENED
Keywords: fixed1.8.1
Resolution: FIXED → ---
Whiteboard: [Fx2 theme change]
Assignee | ||
Comment 4•18 years ago
|
||
I guess this doesn't really belong on the blocker list, given that it existed in 1.5 too, but it would be nice to have Toolbar.png updated to include a "checked" state for the history icon.
No longer blocks: NewTheme
Status: REOPENED → NEW
Reporter | ||
Comment 5•18 years ago
|
||
This belongs on the blocker list as long as there is no way to distinguish between checked and not checked toolbarbuttons. Before the refresh, there was a border which appeared when a toolbarbutton was checked. Now, it is possible to have absolutely no visual indication. If we decide to bring those checked toolbarbutton borders back, then this bug won't matter so much.
Assignee | ||
Comment 6•18 years ago
|
||
We did bring the checked borders back, in bug 348442 and bug 352244.
Comment 7•18 years ago
|
||
We're adding the checked state for history. Looks like the Bookmarks checked state isn't displaying on Pinstripe even though it's in Toolbar.png (and History will be shortly). There is a dark gray background on Pinstripe behind them, so I guess it's not urgent, but it should be fixed at some point.
Michael: the bevels are back in the latest nightly :)
Updated•18 years ago
|
Whiteboard: [Fx2 theme change]
Assignee | ||
Updated•18 years ago
|
Whiteboard: [Fx2 theme change]
Assignee | ||
Comment 8•18 years ago
|
||
OK, I think I see what Michael is talking about. There is no "checked" indication on the history button with current branch builds, because the Linux native theming prevents the standard "checked" styling (different background, bevel) from taking effect. If you set -moz-appearance: none on a checked toolbarbutton using the DOM inspector, the styling appears.
That being said, I see exactly the same thing with Firefox 1.5 on the same machine, so as far as I can tell this still isn't a regression from 1.5.
Comment 9•18 years ago
|
||
I'd take a patch for this, but this isn't a regression, so minusing.
We at least have the image available now...
Flags: blocking-firefox2+ → blocking-firefox2-
Updated•18 years ago
|
Whiteboard: [Fx2 theme change]
Assignee | ||
Comment 10•18 years ago
|
||
Comment 11•18 years ago
|
||
Comment on attachment 238162 [details] [diff] [review]
patch
amazing what minusing will do! ;)
Attachment #238162 -
Flags: review?(mconnor)
Attachment #238162 -
Flags: review+
Attachment #238162 -
Flags: approval1.8.1+
Assignee | ||
Comment 12•18 years ago
|
||
Attachment #238162 -
Attachment is obsolete: true
Attachment #238163 -
Flags: review?(mconnor)
Updated•18 years ago
|
Attachment #238163 -
Flags: review?(mconnor)
Attachment #238163 -
Flags: review+
Attachment #238163 -
Flags: approval1.8.1+
Assignee | ||
Comment 13•18 years ago
|
||
mozilla/browser/themes/winstripe/browser/browser.css 1.17.2.58
This still hasn't been fixed on the trunk, so I guess I'll leave this bug open for that.
Keywords: fixed1.8.1
Assignee | ||
Updated•18 years ago
|
Whiteboard: [Fx2 theme change]
Updated•18 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 18 years ago → 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•