Closed Bug 351263 Opened 18 years ago Closed 18 years ago

Dialog steals focus while navigating combobox in subscription options on feed preview pane

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Product:
Firefox Graveyard
Component:
RSS Discovery and Preview
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 2

People

(Reporter: aaronlev, Assigned: asaf)

References

Details

(Keywords: access, fixed1.8.1, Whiteboard: blocker for bug 350615)

Attachments

(1 file)

patch
(deleted), patch
mconnor
: review+
mconnor
: approval1.8.1+
Details | Diff | Splinter Review 
1. Preview a feed, such as http://www.mozillazine.org/contents.rdf
2. Tab to document
3. Tab to "Subscribe to this feed using" combo box.
4. Press down arrow.

A dialog opens up, and shouldn't
No longer blocks: 350615
Assignee: nobody → bugs.mano
Status: NEW → ASSIGNED
Flags: blocking-firefox2?
Whiteboard: blocker for bug 350615
Target Milestone: --- → Firefox 2
Blocks: 346009, 350615
Attached patch patch (deleted) — — Splinter Review 
ShowS the file picker onlt when subscribing if the  "choose application" option was selected using the keyboard.

One open issue is how to handle the "always use" checkbox when this item is selected, its label in particular. I thought of disabling it, then i realized it would require keyboard-only users to subscribe twice (with the same client reader) in order to be able to tick the checkbox.
Attachment #236674 - Flags: review?(mconnor)
Attachment #236674 - Attachment description: patcb → patch
Flags: blocking-firefox2? → blocking-firefox2+
Comment on attachment 236674 [details] [diff] [review]
patch

looks good!
Attachment #236674 - Flags: review?(mconnor) → review+
Attachment #236674 - Flags: approval1.8.1?
Whiteboard: blocker for bug 350615 → blocker for bug 350615 [baking until 09/08]
mozilla/browser/components/feeds/src/FeedWriter.js 1.14
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment on attachment 236674 [details] [diff] [review]
patch

a=mconnor on behalf of drivers for 1.8 branch checkin
Attachment #236674 - Flags: approval1.8.1? → approval1.8.1+
1.8 branch: mozilla/browser/components/feeds/src/FeedWriter.js 1.2.2.17
Keywords: fixed1.8.1
Whiteboard: blocker for bug 350615 [baking until 09/08] → blocker for bug 350615
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: