Closed
Bug 351575
Opened 18 years ago
Closed 18 years ago
Dereference before null check in |nsTypedSelection::GetRangesForInterval|
Categories
(Core :: DOM: Selection, defect)
Core
DOM: Selection
Tracking
()
RESOLVED
FIXED
People
(Reporter: kherron+mozilla, Assigned: ispiked)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity)
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
ispiked
:
review+
ispiked
:
superreview+
|
Details | Diff | Splinter Review |
This is coverity ID 1025. Please see the sample URL. The variables |aResultCount| and |aResults| are dereferenced before the line that checks whether they're NULL.
|
Reporter | |
Updated•18 years ago
|
Whiteboard: [good first bug]
|
Assignee | |
Comment 1•18 years ago
|
||
Assignee: selection → ispiked
Status: NEW → ASSIGNED
Attachment #237009 -
Flags: superreview?(bryner)
Attachment #237009 -
Flags: review?(brettw)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 237009 [details] [diff] [review]
patch
Looks good, but please re-align the indented parameters to GetRangesForIntervalCOMArray with the first argument.
Attachment #237009 -
Flags: review?(brettw) → review+
|
||
Comment 3•18 years ago
|
||
Just fixes the indentation, nothing else
|
|
||
Updated•18 years ago
|
Attachment #237666 -
Flags: review?
|
|
Assignee | |
Comment 4•18 years ago
|
||
Comment on attachment 237666 [details] [diff] [review]
AG's patch with fixed indentation
Karthik, I will attach a new patch to be checked in (with the indentation fix, of course) once bryner reviews the first patch.
Attachment #237666 -
Attachment is obsolete: true
Attachment #237666 -
Flags: review?
|
|
||
Comment 5•18 years ago
|
||
roger(In reply to comment #4)
> (From update of attachment 237666 [details] [diff] [review] [edit])
> Karthik, I will attach a new patch to be checked in (with the indentation fix,
> of course) once bryner reviews the first patch.
>
roger
|
||
Updated•18 years ago
|
Attachment #237009 -
Flags: superreview?(bryner) → superreview+
|
|
Assignee | |
Comment 6•18 years ago
|
||
Attachment #237009 -
Attachment is obsolete: true
Attachment #239811 -
Flags: superreview+
Attachment #239811 -
Flags: review+
|
|
Assignee | |
Updated•18 years ago
|
Whiteboard: [good first bug] → [checkin needed]
|
||
Comment 7•18 years ago
|
||
Checking in layout/generic/nsSelection.cpp;
/cvsroot/mozilla/layout/generic/nsSelection.cpp,v <-- nsSelection.cpp
new revision: 3.266; previous revision: 3.265
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•