Closed
Bug 351732
Opened 18 years ago
Closed 18 years ago
[FIX] CreateTextNode does useless notifications
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
|
(deleted),
patch
|
sicking
:
review+
sicking
:
superreview+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
sicking
:
review+
sicking
:
superreview+
|
Details | Diff | Splinter Review |
And as a result checks for mutation listeners for no reason. And if there happen to be some, fires pointless mutation events....
|
Assignee | |
Comment 1•18 years ago
|
||
Attachment #237206 -
Flags: superreview?(bugmail)
Attachment #237206 -
Flags: review?(bugmail)
|
|
Assignee | |
Comment 2•18 years ago
|
||
Attachment #237206 -
Attachment is obsolete: true
Attachment #237208 -
Flags: superreview?(bugmail)
Attachment #237208 -
Flags: review?(bugmail)
Attachment #237206 -
Flags: superreview?(bugmail)
Attachment #237206 -
Flags: review?(bugmail)
|
|
Assignee | |
Comment 3•18 years ago
|
||
Attachment #237208 -
Attachment is obsolete: true
Attachment #237209 -
Flags: superreview?(bugmail)
Attachment #237209 -
Flags: review?(bugmail)
Attachment #237208 -
Flags: superreview?(bugmail)
Attachment #237208 -
Flags: review?(bugmail)
Comment on attachment 237208 [details] [diff] [review]
With more cases covered
Wanna check for the same thing in the sinks? At least SinkContext::AddComment in the htmlsink has the same problem
Attachment #237208 -
Attachment is obsolete: false
Attachment #237208 -
Flags: superreview+
Attachment #237208 -
Flags: review+
Attachment #237209 -
Flags: superreview?(bugmail)
Attachment #237209 -
Flags: superreview+
Attachment #237209 -
Flags: review?(bugmail)
Attachment #237209 -
Flags: review+
|
|
Assignee | |
Comment 5•18 years ago
|
||
Fixed. Filed bug 351910 for the sinks.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Comment 6•18 years ago
|
||
doesn't seem testable, or worth the effort to make it so
Flags: in-testsuite-
|
|
||
Comment 7•18 years ago
|
||
wait, we could test this... where are the sample documents, sicking?
Flags: in-testsuite- → in-testsuite?
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•