Open
Bug 351768
Opened 18 years ago
Updated 2 years ago
center Bookmark Toolbar chevron within its button
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
REOPENED
People
(Reporter: aja+bugzilla, Unassigned)
Details
(Keywords: polish)
Attachments
(1 file)
(deleted),
image/png
|
Details |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060907 BonEcho/2.0b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060907 BonEcho/2.0b2
UI nit for winstripe: If the Bookmark Toolbar's chevron were centered within its button, it would appear more XP Luna-like.
Reproducible: Always
Actual Results:
Bookmark Toolbar chevron appears left-aligned within its button
Expected Results:
center Bookmark Toolbar chevron within its button
Reporter | ||
Updated•18 years ago
|
Flags: blocking-firefox2?
Comment 1•18 years ago
|
||
Confirming that it is not centered (but a bit to the left). I doubt if this should be changed in branch, because there is already a big distance between the last bookmark on the toolbar and the chevron in most cases.
In trunk the chevron is always closer to the last bookmark and it that case it would look better if the image was centered.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 2•18 years ago
|
||
Not a regression from Firefox 1.5, not a regression due to the new theme, not a blocker for 2.0. Good polish to have, though, I guess!
Comment 3•18 years ago
|
||
I made a thinking mistake (was still early) but the difference between branch and trunk is that the chevron in branch aways sticks to the right edge, where in trunk it sticks to the last bookmark (should be changed). So the padding won't make any difference for that distance.
With toolbarbutton.chevron {padding-left: 8px !important;} or something like that it will look like the screenshot.
Reporter | ||
Comment 4•18 years ago
|
||
(In reply to comment #3)
> Created an attachment (id=237357) [edit]
> screenshot
>
> With toolbarbutton.chevron {padding-left: 8px !important;} or something like
> that it will look like the screenshot.
>
toolbarbutton.chevron {padding-left: 8px !important;}
looks right to me in both my Bon Echo and Minefield profiles' userchrome.css files.
Reporter | ||
Comment 5•18 years ago
|
||
Looks okay in Minefield without the following in my userchrome.css anymore.
toolbarbutton.chevron {padding-left: 8px !important;}
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070621 Minefield/3.0a6pre ID:2007062120
No idea when this got fixed.
Closing.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 6•18 years ago
|
||
(In reply to comment #5)
> Looks okay in Minefield without the following in my userchrome.css anymore.
>
> toolbarbutton.chevron {padding-left: 8px !important;}
>
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070621
> Minefield/3.0a6pre ID:2007062120
>
> No idea when this got fixed.
>
> Closing.
>
Oops, was looking at wrong profile...it's not fixed.
Going to reopen now that bug 331307 has landed, aligning chevron to right again, since this is the situation where not having chevron centered in its button looked bad.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•2 years ago
|
Severity: trivial → S4
You need to log in
before you can comment on or make changes to this bug.
Description
•