Closed
Bug 352320
Opened 18 years ago
Closed 18 years ago
need a third state for tab scroll right / left: enabled but not hovered
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2
People
(Reporter: moco, Assigned: moco)
References
Details
(Keywords: access, fixed1.8.1, Whiteboard: [Fx2 theme change])
Attachments
(6 files)
need a third state for tab scroll right / left: enabled but not hovered
due to bug #352315, we need a third state for scroll right / left: we
have disabled and we have hovered, but we need a third state to be used when
the scroll right /left buttons are enabled, but not hovered. these images
should match with a non-hovered tab (from tomorrow's build.)
Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Flags: blocking-firefox2?
Target Milestone: --- → Firefox 2
Assignee | ||
Comment 1•18 years ago
|
||
note, we do change the color of the "inner" arrow on hover, but not the background image of the scroll right / left.
we should based these images off of a background tab image (as of today, I just changed them.)
note, this is important for high-contrast mode so that you can see, on mouse over, that the scroll button will do something will clicked.
Comment 2•18 years ago
|
||
Attachment #237968 -
Flags: review?
Comment 3•18 years ago
|
||
Attachment #237969 -
Flags: review?
Comment 4•18 years ago
|
||
btw, I think tab-arrow-end-bkgnd.png / tab-arrow-start-bkgnd.png should be renamed to tab-arrow-end-bkgnd-hover.png / tab-arrow-start-bkgnd-hover.png
Assignee | ||
Comment 5•18 years ago
|
||
testing out dao's images now.
> btw, I think tab-arrow-end-bkgnd.png / tab-arrow-start-bkgnd.png should be
> renamed to tab-arrow-end-bkgnd-hover.png / tab-arrow-start-bkgnd-hover.png
I agree, and I've done that and it will be part of my patch.
Assignee | ||
Comment 6•18 years ago
|
||
Attachment #238085 -
Flags: review?(mconnor)
Assignee | ||
Comment 7•18 years ago
|
||
Assignee | ||
Comment 8•18 years ago
|
||
Updated•18 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
Comment 9•18 years ago
|
||
Comment on attachment 238085 [details]
patch, uses new images from dao, renames images
looks good! thanks Dao and Seth!
Attachment #238085 -
Flags: review?(mconnor)
Attachment #238085 -
Flags: review+
Attachment #238085 -
Flags: approval1.8.1+
Assignee | ||
Comment 10•18 years ago
|
||
fix landed on the branch.
Comment 11•18 years ago
|
||
(In reply to comment #10)
> fix landed on the branch.
>
See Screenshot.
Left and Right Scroll buttons look to be having different colors in 'disabled' state. While the right button resembles the new 'background tab' color, the left scroll button resembles the older 'background tab' color.
Comment 12•18 years ago
|
||
(In reply to comment #11)
> Left and Right Scroll buttons look to be having different colors in 'disabled'
> state.
This might be related to bug 352323, it's worth rechecking after that's fixed.
Updated•18 years ago
|
Attachment #237968 -
Flags: review?
Updated•18 years ago
|
Attachment #237969 -
Flags: review?
Comment 13•6 years ago
|
||
Keywords: sec508
You need to log in
before you can comment on or make changes to this bug.
Description
•