Closed
Bug 352510
Opened 18 years ago
Closed 17 years ago
Unsupported windows versions need error message when attempting to install
Categories
(Firefox :: Installer, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9beta1
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
Attachments
(2 files, 2 obsolete files)
(deleted),
image/png
|
beltzner
:
first-review+
|
Details |
(deleted),
patch
|
moco
:
first-review+
|
Details | Diff | Splinter Review |
Spinoff of Bug 330208 for the installer.
Assignee | ||
Comment 1•18 years ago
|
||
Note: both bug 330208 and bug 352420 can be fixed without fixing this bug so even though this bug is set to block these bugs this bug really doesn't block them
Assignee | ||
Updated•18 years ago
|
Assignee | ||
Comment 2•18 years ago
|
||
beltzner, could you review the screenshot and provide a new string if this isn't good enough. btw: though I'd like to just provide a link to our requirements page doing so would be a PITA so I took the KISS approach.
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #255142 -
Flags: first-review?(beltzner)
Assignee | ||
Comment 3•18 years ago
|
||
Just to keep track of the changes needed and get this out of my tree.
Comment 4•18 years ago
|
||
Comment on attachment 255142 [details]
screenshot of dialog
I'd rather not enumerate the entire list of good applications, as every successive version of Windows would require us to revisit this, and ye gods, there's like a bajillion versions of Vista. :) Maybe ..:
Sorry, &shortName can't be installed. This version of &shortName requires Microsoft Windows 2000 or newer.
Attachment #255142 -
Flags: first-review?(beltzner) → first-review-
Assignee | ||
Comment 5•18 years ago
|
||
beltzner, not a problem and thanks!
Attachment #255142 -
Attachment is obsolete: true
Attachment #255183 -
Flags: first-review?
Assignee | ||
Updated•18 years ago
|
Attachment #255183 -
Flags: first-review? → first-review?(beltzner)
Assignee | ||
Comment 6•18 years ago
|
||
Attachment #255146 -
Attachment is obsolete: true
Attachment #255184 -
Flags: first-review?(sspitzer)
Comment 7•18 years ago
|
||
about the UI, is there any sort of existing wordage from other apps (like when you try to install IE7 on windows 98) that we could steal?
Assignee | ||
Comment 8•18 years ago
|
||
(In reply to comment #7)
> about the UI, is there any sort of existing wordage from other apps (like when
> you try to install IE7 on windows 98) that we could steal?
I'm sure there is but I highly suspect that it would be much more formal than the wordage we tend to use in our app and I tend to prefer the wordage from beltzner.
Assignee | ||
Comment 9•18 years ago
|
||
btw: upgrading NSIS will not break the other apps if they don't specify this... it has a default value of none and Vista special cases NSIS installers to auto require elevation though I will patch the other apps.
Comment 10•18 years ago
|
||
Comment on attachment 255184 [details] [diff] [review]
patch - requires upgrading NSIS
r=sspitzer
Attachment #255184 -
Flags: first-review?(sspitzer) → first-review+
Comment 11•18 years ago
|
||
as with bug #370457, but this mean we need to ask our buddies in release to upgrade NSIS on the build machines. And, that would only be for trunk build machines, right?
and this patch looks like something mscott might also need to worry about, for
tbird built of the trunk.
Assignee | ||
Comment 12•18 years ago
|
||
(In reply to comment #9)
please ignore... this was meant for bug 370457
Assignee | ||
Comment 13•18 years ago
|
||
(In reply to comment #11)
> as with bug #370457, but this mean we need to ask our buddies in release to
> upgrade NSIS on the build machines. And, that would only be for trunk build
> machines, right?
As with bug 370457 this bug depends on bug 370438. The current plan is only for trunk though drivers may decide this is wanted on the branch... I'm fine either way though I want this on the trunk for a while before it would ever be allowed on the branch.
> and this patch looks like something mscott might also need to worry about, for
> tbird built of the trunk.
Agreed and I'll take care of this bug for Sunbird and Thunderbird.
Updated•18 years ago
|
Attachment #255183 -
Flags: first-review?(beltzner) → first-review+
Assignee | ||
Updated•17 years ago
|
Target Milestone: --- → mozilla1.9beta1
Assignee | ||
Updated•17 years ago
|
Flags: blocking1.9?
Assignee | ||
Updated•17 years ago
|
Updated•17 years ago
|
Version: unspecified → Trunk
Flags: blocking1.9? → blocking1.9+
Assignee | ||
Comment 14•17 years ago
|
||
note: I will most likely land this in one of the patches in bug 392303
Depends on: 392303
Assignee | ||
Updated•17 years ago
|
Target Milestone: mozilla1.9 M8 → mozilla1.9 M9
Assignee | ||
Comment 15•17 years ago
|
||
Fixed by the checkin of bug 392303
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 16•17 years ago
|
||
The string addition was checked in separately
Checking in mozilla/browser/locales/en-US/installer/custom.properties;
/cvsroot/mozilla/browser/locales/en-US/installer/custom.properties,v <-- custom.properties
new revision: 1.9; previous revision: 1.8
done
Updated•1 year ago
|
Component: NSIS Installer → Installer
Product: Toolkit → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•