I've already done some work toward making checksetup.pl localizeable, by creating Bugzilla::Install::get_text. Now I just need to use that in other places, and make the error messages and status messages localizable. Some messages can't be localized, because they're printed out before templates can even be used. But otherwise, most messages can be localized.

Okay, this greatly improves the i18n of checksetup. There are some messages that we can't yet localize. The problem is that we need to be able to safely create a Template object when parameters aren't even set yet. So all that code needs to expect the possibility of there being no parameters. We also need to be able to create at template object with no database available. I'll have to fix that in another bug, but for now you can see that a lot of messages are now templatized. Some messages will probably never be templatized. The idea is that I'm templatizing two types of messages: 1) Messages that are easy to templatize. 2) Messages that tell the user something they really need to know. Granting myself review as module owner.

Checking in Bugzilla.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla.pm,v <-- Bugzilla.pm new revision: 1.49; previous revision: 1.48 done Checking in checksetup.pl; /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v <-- checksetup.pl new revision: 1.544; previous revision: 1.543 done Checking in Bugzilla/DB.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB.pm,v <-- DB.pm new revision: 1.87; previous revision: 1.86 done Checking in Bugzilla/Group.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Group.pm,v <-- Group.pm new revision: 1.17; previous revision: 1.16 done Checking in Bugzilla/Install.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install.pm,v <-- Install.pm new revision: 1.9; previous revision: 1.8 done Checking in Bugzilla/Template.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Template.pm,v <-- Template.pm new revision: 1.61; previous revision: 1.60 done Checking in Bugzilla/Util.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v <-- Util.pm new revision: 1.53; previous revision: 1.52 done Checking in Bugzilla/Install/Filesystem.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Filesystem.pm,v <-- Filesystem.pm new revision: 1.14; previous revision: 1.13 done Checking in Bugzilla/Install/Localconfig.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Localconfig.pm,v <-- Localconfig.pm new revision: 1.5; previous revision: 1.4 done Checking in Bugzilla/User/Setting.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/User/Setting.pm,v <-- Setting.pm new revision: 1.9; previous revision: 1.8 done Checking in template/en/default/global/code-error.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/code-error.html.tmpl,v <-- code-error.html.tmpl new revision: 1.86; previous revision: 1.85 done Checking in template/en/default/global/messages.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/messages.html.tmpl,v <-- messages.html.tmpl new revision: 1.44; previous revision: 1.43 done

Yes it works, but now there's a problem running checksetup.pl from non UTF8-capable console. We have messages.html.tmpl in UTF-8 which is right, but windows people (besides Cygwin bash users) do use different text charsets -- for example, Windows-1251 here in Russia. Keeping messages in different charsets within single file -- would be really a pain. Not sure what to do: o implement 'FILTER consolecharset'? o use builtin Perl codepage tools? Worth reopening this or filing new bug?

I think you should file a new bug--we can do something to translate from UTF-8 into the console's charset.