Closed
Bug 353087
Opened 18 years ago
Closed 6 years ago
Feed preview needs to infer text direction (RTL) from feed language
Categories
(Firefox Graveyard :: RSS Discovery and Preview, defect, P5)
Firefox Graveyard
RSS Discovery and Preview
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: sayrer, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: rtl)
Attachments
(3 files)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review |
a sad, but true, reality. Feeds in languages such as "he-IL" need to have their default text direction set to RTL, for text-only elements.
I've CCed drivers people because some of our default localized feeds are getting bitten by this bug.
Reporter | ||
Updated•18 years ago
|
Whiteboard: good first bug
Reporter | ||
Updated•18 years ago
|
Whiteboard: good first bug
Comment 1•18 years ago
|
||
Inferring direction from language is an explicit MUST NOT in the HTML spec: http://www.w3.org/TR/REC-html40/struct/dirlang.html#idx-lang_attribute-1
Comment 2•18 years ago
|
||
What are the symptoms of this problem? Could they be fixed by explicit embeddings?
Comment 3•18 years ago
|
||
It's a MUST NOT in HTML because HTML has options. Ignoring tiresome arguments about the intention of inadequate specs, RSS titles are plain text, not HTML.
The symptom is that the feed preview for http://www.haayal.co.il/xml/rss shows the HTML descriptions properly rtl, and the plain text descriptions ltr.
The best overview of the problem I've seen is http://www.cubicgarden.com/blojsom/blog/cubicgarden/xml/Semantic+web/2005/05/24/The_problem_with_Language_RSS.html from Ian Forrester, whose day job is (or at least was at the time) producing feeds like http://www.bbc.co.uk/blogs/persian/atom.xml which we fail to render rtl in preview because the xml:lang="fa" (which isn't covering enough of the feed) doesn't tip us off.
However, I don't think it's a 2.0 blocker, since our default localized feeds are the feeds least likely to ever see the preview page, and anyone who uses RSS and reads rtl is used to having things suck.
Comment 4•18 years ago
|
||
(In reply to comment #3)
> It's a MUST NOT in HTML because HTML has options. Ignoring tiresome arguments
> about the intention of inadequate specs, RSS titles are plain text, not HTML.
I don't have anything against using the directionality of the content to determine the text direction; that would be a dupe of bug 347510
Reporter | ||
Comment 5•18 years ago
|
||
This attachment shows IE7 rendering a Hebrew feed with no <language> tag on the left side, and the same feed with <language>he-IL</language>.
(In reply to comment #4)
>
> I don't have anything against using the directionality of the content to
> determine the text direction; that would be a dupe of bug 347510
I want to do the right thing, but where we have a choice, I want to be compatible with IE7. Take a look at the third item title in the screenshot. They get the text direction right, but the overall direction and alignment is wrong. Can we get it right without using <language> to set bidi values?
(In reply to comment #2)
> What are the symptoms of this problem?
Busted titles in RTL feeds (wrong side of the page).
> Could they be fixed by explicit embeddings?
I am not sure I understand your question, but one possible solution I heard was to patch the RTL builds and fix the rest of them in 2.0.0.1. I don't know enough about Firefox release management to have an opinion.
Reporter | ||
Comment 6•18 years ago
|
||
Here is Bon Echo previewing the same feed. Same as IE7 when no <language> value is available.
Comment 7•18 years ago
|
||
Description of IE7's algo: http://blogs.msdn.com/rssteam/archive/2007/05/17/reading-feeds-in-right-to-left-order.aspx
Flags: blocking-firefox3?
Reporter | ||
Comment 8•18 years ago
|
||
this adds xml:lang support, need to mess with it a little bit to get RSS2 right.
Comment 9•18 years ago
|
||
OK, let's do this for interoperability, but please don't follow this part of IE's algo:
"the language value must be in lowercase (e.g. ar-SA, he-IL, ur-PK, etc.)"
That is Just Wrong -- language tags are always case-insensitive (RFC 4646)
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Updated•17 years ago
|
Target Milestone: --- → Firefox 3 alpha6
Updated•17 years ago
|
Target Milestone: Firefox 3 alpha6 → Firefox 3 beta1
Updated•17 years ago
|
Target Milestone: Firefox 3 M7 → Firefox 3 M8
Comment 10•17 years ago
|
||
Robert, what's the status here? Will this make M8? If you're still wrapped up in content-restriction, it can slide to M9
Comment 11•17 years ago
|
||
Moving to M9 per discussion with sayrer.
Target Milestone: Firefox 3 M8 → Firefox 3 M9
Comment 12•17 years ago
|
||
moving out bugs that don't need to block b1
Target Milestone: Firefox 3 M9 → Firefox 3 M10
Updated•17 years ago
|
Target Milestone: Firefox 3 M10 → Firefox 3 M11
Updated•17 years ago
|
Priority: -- → P5
Updated•17 years ago
|
Flags: wanted-firefox3+
Flags: blocking-firefox3-
Flags: blocking-firefox3+
Priority: P5 → P4
Target Milestone: Firefox 3 Mx → Firefox 3 M11
Comment 13•17 years ago
|
||
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl
Comment 14•16 years ago
|
||
Robert, any status updates here?
Updated•12 years ago
|
Assignee: sayrer → nobody
Target Milestone: Firefox 3 beta3 → ---
Comment 18•11 years ago
|
||
BUMP?
Comment 19•11 years ago
|
||
Can't we use dir=auto here to address this?
Updated•7 years ago
|
Priority: P4 → P5
Comment 20•6 years ago
|
||
The feed preview code has been removed by bug 1477669.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Updated•6 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•