Closed
Bug 353285
Opened 18 years ago
Closed 18 years ago
nsresult rv used unitialized in nsXMLHttpRequest::Open
Categories
(Core :: XML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: sciguyryan)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity, klocwork)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•18 years ago
|
||
First try at a simple patch, early breakout if !cc, rv initialized as NS_OK.
Attachment #239318 -
Flags: superreview?(bzbarsky)
Attachment #239318 -
Flags: review?(bzbarsky)
Comment 2•18 years ago
|
||
Comment on attachment 239318 [details] [diff] [review] Patch >Index: nsXMLHttpRequest.cpp >+ if (!cc) { >+ return NS_ERROR_FAILURE; >+ } No, this is wrong. That will make it completely impossible to do XMLHttpRequest from C++, which is highly undesirable.
Attachment #239318 -
Flags: superreview?(bzbarsky)
Attachment #239318 -
Flags: superreview-
Attachment #239318 -
Flags: review?(bzbarsky)
Attachment #239318 -
Flags: review-
Assignee | ||
Comment 3•18 years ago
|
||
Second try.
Assignee: xml → sciguyryan+bugzilla
Attachment #239318 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #239362 -
Flags: review?(bzbarsky)
Updated•18 years ago
|
Attachment #239362 -
Flags: superreview+
Attachment #239362 -
Flags: review?(bzbarsky)
Attachment #239362 -
Flags: review+
Comment 4•18 years ago
|
||
Checked in. Thanks for the patch!
Updated•18 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•