Closed
Bug 353446
Opened 18 years ago
Closed 18 years ago
Context-menu on an empty area of the Personal Toolbar is broken.
Categories
(SeaMonkey :: Bookmarks & History, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: stephend, Unassigned)
Details
(Keywords: fixed-seamonkey1.1b, regression)
Attachments
(1 file)
(deleted),
patch
|
neil
:
review+
iannbugzilla
:
approval-seamonkey1.1b+
|
Details | Diff | Splinter Review |
Bug 50504 broke context-menu creation of "New Folder" functionality on an empty area of the Personal Toolbar.
Steps to Reproduce:
1. Right-click the Personal Toolbar in an empty area, in an attempt to create a new folder there.
Expected Results:
Context menu is created.
Actual Results:
No context menu appears.
Reporter | ||
Comment 1•18 years ago
|
||
Works: 2006-08-05 of SeaMonkey trunk under Windows XP.
Fails: 2006-08-06 of SeaMonkey trunk under Windows XP.
Oops! Here's a patch that restores that functionality.
Attachment #239323 -
Flags: review?(neil)
Comment on attachment 239323 [details] [diff] [review]
Patch to fix context menu
r=me if neil says it counts.
Comment 4•18 years ago
|
||
Comment on attachment 239323 [details] [diff] [review]
Patch to fix context menu
sr=me
I see other code has to special-case bookmarks-ptf because isBTBookmark doesn't.
Attachment #239323 -
Flags: review?(neil) → review+
Thanks for the reviews. Could this patch be checked in on the trunk?
(In reply to comment #4)
> I see other code has to special-case bookmarks-ptf because isBTBookmark
> doesn't.
I also noticed that and considered patching isBTBookmark instead, but I didn't want to accidentally break another part of the bookmark menus in the process.
Reporter | ||
Comment 6•18 years ago
|
||
2006-09-20 14:34 neil%parkwaycc.co.uk mozilla/xpfe/components/bookmarks/resources/bookmarksMenu.js 1.28 1/1 Bug 353446 Restore context menu to empty area of personal toolbar p=paradigmk@technodrome.com r=CTho sr=me
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 7•18 years ago
|
||
Verified FIXED using build 2006-09-20-18 of Windows XP SeaMonkey trunk; I wish I would have filed this sooner! Thanks for the instant turn-around, though!
Status: RESOLVED → VERIFIED
Comment on attachment 239323 [details] [diff] [review]
Patch to fix context menu
No problem, and thanks to Neil for the checkin. Since bug 50504 is also on the branch, I'm requesting approval for 1.1b as well.
Attachment #239323 -
Flags: approval-seamonkey1.1b?
Attachment #239323 -
Flags: approval-seamonkey1.1b? → approval-seamonkey1.1b+
Thanks for the approval, Ian. I just need a branch checkin to finish up this bug.
Updated•18 years ago
|
Keywords: fixed-seamonkey1.1b
You need to log in
before you can comment on or make changes to this bug.
Description
•