Closed
Bug 353655
Opened 18 years ago
Closed 13 years ago
--enable-timeline doesn't build
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: Pike, Unassigned)
References
(Blocks 1 open bug, )
Details
Attachments
(2 files)
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
benjamin
:
review-
|
Details | Diff | Splinter Review |
nsITimelineService.idl defines a set of functions to actually implement the macros it exposes, and those function are declared as
extern "C" NS_COM nsresult
and nsTimelineService.cpp uses
PR_IMPLEMENT(nsresult)
to implement that. That somehow doesn't make our build happy in some config. I use a xulrunner opt dynamic build, but didn't disable libxul. Not sure if that would change something, but I guess that in our new linking world, probably both sides in the timeline service are wrong.
Benjamin?
Comment 1•18 years ago
|
||
what is the error log look like?
Reporter | ||
Comment 2•18 years ago
|
||
c:/Sources/full/mozilla/xpcom/ds/nsTimelineService.cpp(332) : error C2375: 'NS_TimelineForceMark' : redefinition; different linkage
../../dist/include/xpcom\nsITimelineService.h(254) : see declaration of 'NS_TimelineForceMark'
is the first, full build log attached.
Comment 3•15 years ago
|
||
Use PR_EXTERN in nsITimelineService.idl.
I am not sure that use of PR_EXTERN in idl is good manner of Mozilla.
Comment 4•15 years ago
|
||
On WinCE build, there are the same error in comment #1.
And on Linux with gcc-4.3.3, there are some warnings like the following:
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp: In function 'nsresult NS_TimelineForceMark(const char*, ...)':
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp:331: warning: 'nsresult NS_TimelineForceMark(const char*, ...)': visibility attribute ignored because it
../../dist/include/xpcom/nsITimelineService.h:254: warning: conflicts with previous declaration here
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp: In function 'nsresult NS_TimelineMark(const char*, ...)':
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp:340: warning: 'nsresult NS_TimelineMark(const char*, ...)': visibility attribute ignored because it
../../dist/include/xpcom/nsITimelineService.h:253: warning: conflicts with previous declaration here
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp: In function 'nsresult NS_TimelineStartTimer(const char*)':
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp:360: warning: 'nsresult NS_TimelineStartTimer(const char*)': visibility attribute ignored because it
../../dist/include/xpcom/nsITimelineService.h:255: warning: conflicts with previous declaration here
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp:387: warning: 'nsresult NS_TimelineStopTimer(const char*)': visibility attribute ignored because it
../../dist/include/xpcom/nsITimelineService.h:256: warning: conflicts with previous declaration here
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp:414: warning: 'nsresult NS_TimelineMarkTimer(const char*, const char*)': visibility attribute ignored because it
../../dist/include/xpcom/nsITimelineService.h:258: warning: conflicts with previous declaration here
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp:447: warning: 'nsresult NS_TimelineResetTimer(const char*)': visibility attribute ignored because it
../../dist/include/xpcom/nsITimelineService.h:257: warning: conflicts with previous declaration here
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp:467: warning: 'nsresult NS_TimelineIndent()': visibility attribute ignored because it
../../dist/include/xpcom/nsITimelineService.h:259: warning: conflicts with previous declaration here
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp:479: warning: 'nsresult NS_TimelineOutdent()': visibility attribute ignored because it
../../dist/include/xpcom/nsITimelineService.h:260: warning: conflicts with previous declaration here
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp:491: warning: 'nsresult NS_TimelineEnter(const char*)': visibility attribute ignored because it
../../dist/include/xpcom/nsITimelineService.h:261: warning: conflicts with previous declaration here
/home/zoe/hg/mozilla-central/xpcom/ds/nsTimelineService.cpp:500: warning: 'nsresult NS_TimelineLeave(const char*)': visibility attribute ignored because it
../../dist/include/xpcom/nsITimelineService.h:262: warning: conflicts with previous declaration here
Comment 5•15 years ago
|
||
(In reply to comment #4)
> On WinCE build, there are the same error in comment #1.
This meant comment #2, of course.
Updated•15 years ago
|
Attachment #373022 -
Flags: review?(benjamin)
Comment 6•15 years ago
|
||
Comment on attachment 373022 [details] [diff] [review]
Proposed patch
I think the timeline service is a bad API that should be removed.
We might want to add a simple timeline service back, but it should be always on and we should come up with useful marking points rather than letting it rot all the time and having hit and miss timeline marks based on who's using it right now.
Attachment #373022 -
Flags: review?(benjamin) → review-
Comment 7•13 years ago
|
||
nsITimelineService was removed by bug 579571, so this is wontfix.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•