Closed Bug 354288 Opened 18 years ago Closed 18 years ago

Use a weakly cached accessible reference in widget/

Categories

(Core :: Disability Access APIs, enhancement)

PowerPC
macOS
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: hwaara, Assigned: hwaara)

References

Details

Attachments

(1 file)

I did some profiling of the accessible code performs when using AccessibilityVerifier.app to go through the whole accessibility hierarchy on www.dn.se (big swedish news page). (This is a *very* expensive operation, and good for profiling) Turns out around 20% of the time is spent sending off events from widget, to get an nsIAccessible. This accessible could be (weakly) cached instead.
Attached patch Use a weakref, v1 (deleted) — Splinter Review
This will try to use an (existing) weak ref. If it's null, it means the accessible has gone away, so we re-get it, and re-cache it. Yay for nsIWeakReferences!
Attachment #240113 - Flags: review?(joshmoz)
Attachment #240113 - Flags: review?(joshmoz) → review+
Checked in.
Blocks: osxa11y
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: