Not interested in Mozilla any more Reporter
	Description • 18 years ago

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1b2) Gecko/20060821 SeaMonkey/1.1a
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1b2) Gecko/20060821 SeaMonkey/1.1a

Pressing command-up arrow causes webpage to be with a different page from the same site. Previously it took you to the top of the current page. Command-down arrow still takes you to the bottom of the current page. The existing behavior is an absolute must for laptop users who do not have 'home' and 'end' keys.

Reproducible: Always

Steps to Reproduce:
1. Go to a page
2. Press command-up arrow


Actual Results:  
Page is replaces, usually with the main page for that site.

Expected Results:  
Page should remain and you should be taken to the top of the page.

	Samuel Sidler (old account; do not CC)
	Comment 1 • 18 years ago

I can confirm this behavior, but am changing the summary a bit.

In SeaMonkey 1.0.x, pressing cmd-up would take you to the top of the page, if you had scrolled it.

In SeaMonkey 1.1 and trunk, pressing cmd-up takes you up a directory in the path. For example, if you were at http://localhost/testing/123/, cmd-up would take you to http://localhost/testing/.

This appears to be a regression, but I'm sure it's actually the casualty of a new feature. Unfortunately, I can't find the bug that added this behavior. As such, I'm not confirming it because there may have been discussion already.

	neil@parkwaycc.co.uk Assignee
	Comment 2 • 18 years ago

Sorry, when I fixed bug 33684 I didn't realise Cmd+Up was already in use.

What key would you like it to be, if any? (You can choose any key you like because it goes in platformNavigationBindings.xul).

	Stefan [:stefanh]
	Comment 3 • 18 years ago

(Cmd+Up also moves tab left)

How about Cmd+Shift+Up ? I don't think it's used anywhere.

	Stefan [:stefanh]
	Comment 4 • 18 years ago

Hmm, maybe Alt+Up works as well.

	Samuel Sidler (old account; do not CC)
	Comment 5 • 18 years ago

Technically, cmd-shift-up used to for selecting "from here to the top the of page". Alt/option- or ctrl- up seem reasonable though.

alt/option-up go to the top of textareas though, so as long as it doesn't interfere with that (which it shouldn't because focus is different), then it should be good.

	neil@parkwaycc.co.uk Assignee
	Comment 6 • 18 years ago

It's actually alt-up on the other platforms, but I changed it to cmd-up to match the back and forward keys... are we agreed on alt-up?

	Stefan [:stefanh]
	Comment 7 • 18 years ago

(In reply to comment #6)
> It's actually alt-up on the other platforms, but I changed it to cmd-up to
> match the back and forward keys... are we agreed on alt-up?
> 

Alt+Up sounds good to me. If you bother to update Help on trunk (otherwise I can), Alt is Opt on mac ;-)

	Samuel Sidler (old account; do not CC)
	Comment 9 • 18 years ago

Comment on attachment 254462 [details] [diff] [review]
Proposed patch

I don't build SeaMonkey, but this change looks good to me.

r=me

	neil@parkwaycc.co.uk Assignee
	Comment 10 • 18 years ago

Fix checked in to the trunk.

	Ian Neal
	Comment 11 • 18 years ago

Comment on attachment 254462 [details] [diff] [review]
Proposed patch

a=me for SM1.1.1 (one more needed)

	neil@parkwaycc.co.uk Assignee
	Comment 12 • 18 years ago

(In reply to comment #11)
>(From update of attachment 254462 [details] [diff] [review])
>a=me for SM1.1.1 (one more needed)
I don't think it is, so I've checked it in to the branch.

	Robert Kaiser
	Comment 13 • 18 years ago

Comment on attachment 254462 [details] [diff] [review]
Proposed patch

a+ per correct notion on Comment #12