We landed bug 319777 with placeholder icons to get it landed; we need proper British icons to finish the job ;) Per our last Camino team conversation on this, we want to go with the top row of icons in attachment 239236 [details] (in the URL field). However, they need to be just the "icon" triangle parts (on a transparent background, and only the "enabled" state; the tab bar/Camino/Cocoa does the disabling and pressed states itself). tab_scroll_button_left.tif tab_scroll_button_right.tif

Do you need these to be square at all? At the moment they are 7x10px.

Thanks for the images, John! They look great. With the new icons the left divider was much too clingy. This patch appears to make the icon more central and is just to tidy things up.

Comparison for Hakan. Top is with patch, bottom is without patch.

Comment on attachment 241313 [details] [diff] [review] The smallest patch ever, makes the left icon more central Looks good for the right icon, but the left icon will need some more work (apparently delliot will fix it in a follow-up, because it involves some other things).

Garr. Replace "left" with "right" and vice versa. Left is good, right = more work.

This code/icon combination looks way too low in the tab bar. From some quick rulering, it looks like they're aligned equally *including the bottom "bevel" strip, when they should be aligned vertically based on the actual "empty tab space". I'm not sure if this should be done in code, or if we should just make icons that start a few px higher.

Comment on attachment 241313 [details] [diff] [review] The smallest patch ever, makes the left icon more central >-static const int kTabBarMarginWhenOverflowTabs = 16; // left margin for tab bar when overflowing >+static const int kTabBarMarginWhenOverflowTabs = 20; // left margin for tab bar when overflowing While you are changing this line, could you fix the comment? It's not the left margin, it's just the margin (since it applies to both sides)

Comment on attachment 241313 [details] [diff] [review] The smallest patch ever, makes the left icon more central sr=pink

Fixed on trunk