Closed
Bug 356204
Opened 18 years ago
Closed 16 years ago
Need to change the class names of preference panes from Chimera to Camino
Categories
(Camino Graveyard :: Preferences, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: froodian, Assigned: bugzilla-graveyard)
References
Details
(Whiteboard: [Good First Bug])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
froodian
:
review+
stuart.morgan+bugzilla
:
superreview-
|
Details | Diff | Splinter Review |
Our Preference panes classes are named OrgMozillaChimeraPreferenceFoo - we should change these to OrgMozillaCaminoPreferenceFoo (when we do this, we need to make sure we catch the NSPrincipalClass in the Info-Foo.plist files too)
|
Reporter | |
Updated•18 years ago
|
Whiteboard: [Good First Bug]
|
|
Reporter | |
Updated•18 years ago
|
Assignee: nobody → peter.a.jaros
|
||
Comment 1•18 years ago
|
||
Mostly a supervised search-and-replace. According to Spotlight, no untouched files contain OrgMozillaChimeraPreference. Build succeeds and prefpanes load.
Attachment #254564 -
Flags: review?(stridey)
|
|
Reporter | |
Comment 2•18 years ago
|
||
This patch doesn't apply cleanly in WebFeatures.h
|
|
||
Comment 3•18 years ago
|
||
Sorry, didn't realize my tree was out of date. This one's diff'd off of fresh source.
Attachment #254564 -
Attachment is obsolete: true
Attachment #254705 -
Flags: review?(stridey)
Attachment #254564 -
Flags: review?(stridey)
|
|
Reporter | |
Comment 4•18 years ago
|
||
Comment on attachment 254705 [details] [diff] [review]
Non-bitrotted version
Looks good, r=me
Attachment #254705 -
Flags: superreview?(stuart.morgan)
Attachment #254705 -
Flags: review?(stridey)
Attachment #254705 -
Flags: review+
|
||
Comment 5•18 years ago
|
||
Comment on attachment 254705 [details] [diff] [review]
Non-bitrotted version
>- [NSBundle bundleForClass:[OrgMozillaChimeraPreferenceAppearance class]], @"");
>+ [NSBundle bundleForClass:[OrgMozillaCaminoPreferenceAppearance class]], @"");
Make this [NSBundle bundleForClass:[self class]] to avoid having this kind of thing happen next time we change names ;)
The Chimera names also appear in all the nibs, since they all had the corresponding header files dropped in, and those should all be changed at the same time. Since that involves touching all the nibs, lets revisit this post-1.1
Attachment #254705 -
Flags: superreview?(stuart.morgan) → superreview-
|
||
Comment 6•17 years ago
|
||
We fixed this for the General preference pane in bug 408400.
Can we fix this pane-by-pane as we fix other things in their nibs?
Flags: camino1.6b1?
|
|
||
Comment 8•17 years ago
|
||
Certainly.
|
|
||
Comment 9•17 years ago
|
||
Bug 354975 fixes this for the Privacy preference pane.
|
|
||
Comment 10•17 years ago
|
||
Bug 278820 fixes this for the Appearance preference pane.
|
|
||
Comment 11•17 years ago
|
||
Bug 241100 fixes this for the Tabs preference pane.
|
|
||
Comment 12•17 years ago
|
||
Bug 384791 fixes this for the Web Features preference pane.
|
|
||
Comment 13•17 years ago
|
||
minusing for 1.6; if this happens as a side effect of other changes, great, but it's not critical.
Flags: camino1.6b3? → camino1.6b3-
|
Assignee | |
Comment 14•16 years ago
|
||
Bug 411189 contains fixes for the remaining three: Downloads, Security, and History.
Hardware: Macintosh → All
|
|
Assignee | |
Comment 15•16 years ago
|
||
Stealing from peeja based on comment 14, after which this bug will be FIXED.
FIXED by the checkin for bug 411189. Nice work all.
My kingdom for bug 452888!
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•