Open Bug 356417 Opened 18 years ago Updated 2 years ago

Cropping of xul buttons does not work anymore

Categories

(Core :: Layout, defect)

defect

Tracking

()

REOPENED

People

(Reporter: martijn.martijn, Unassigned)

References

Details

(Keywords: regression, testcase)

Attachments

(1 file)

(deleted), application/vnd.mozilla.xul+xml
Details
This is a follow-up from bug 354243. From bug 354243, comment 6: " The label should overflow the button. The crop attribute should be used to crop the label, but that doesn't seem to work :( " I'll attach a testcase. The testcase works in Mozilla1.7, so I'm marking this a regression.
Attached file testcase (deleted) —
Button text cropping does not work anymore on linux too. testcase: http://www.mozilla.org/projects/xul/tests/buttons.xul
OS: Windows XP → All
Hardware: x86 → All
Flags: wanted1.9.2?
Flags: wanted1.9.2?
Flags: wanted1.9.2-
Flags: blocking1.9.2-
@testcase from comment 1: ok Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060125 Firefox/1.6a1 fails Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060126 Firefox/1.6a1 => caused by check-in of Bug 317375 probably @testcase from comment 2: ok Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050301 Firefox/1.0+ specifically "1.8b2: 2005030106" fails Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050302 Firefox/1.0+ specifically "1.8b2: 2005030206" range => http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-03-01+05%3A00&maxdate=2005-03-02+07%3A00&cvsroot=%2Fcvsroot i presume comment 2 describes another (yet unfilled?) bug.
This bug results from Bug 414711 (In a cropped label, text overruns label width (text size computed wrong?)). You can make the cropping work for both bugs by setting flex="1" for the label. It only works for flex-values bigger than 1. I tested it, by adding flex to the label-child of the xbl-binding of the button and the buttons where correctly cropped.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: