Closed
Bug 356590
Opened 18 years ago
Closed 18 years ago
Clean up nsContextMenu and make it a bit more window-agnostic
Categories
(Firefox :: Menus, defect)
Firefox
Menus
Tracking
()
RESOLVED
FIXED
Firefox 3 alpha1
People
(Reporter: asaf, Assigned: asaf)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Clean up nsContextMenu and make it a bit more window-agnostic
Comment 1•18 years ago
|
||
yay!
Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•18 years ago
|
||
Attachment #242265 -
Flags: review?(gavin.sharp)
Comment 3•18 years ago
|
||
Comment on attachment 242265 [details] [diff] [review]
checkpoint
.getComputedStyle(elem, "").getPropertyValue( prop );
nit: unnecessary spaces around parens
I think setItemAttr should be put in a global place, that code pattern is repeated a lot (I can file a new bug for that).
Attachment #242265 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 4•18 years ago
|
||
Attachment #242265 -
Attachment is obsolete: true
Assignee | ||
Comment 5•18 years ago
|
||
Checking in browser/base/jar.mn;
/cvsroot/mozilla/browser/base/jar.mn,v <-- jar.mn
new revision: 1.109; previous revision: 1.108
done
Checking in browser/base/content/browser-context.inc;
/cvsroot/mozilla/browser/base/content/browser-context.inc,v <-- browser-contex
t.inc
new revision: 1.27; previous revision: 1.26
done
Checking in browser/base/content/browser-sets.inc;
/cvsroot/mozilla/browser/base/content/browser-sets.inc,v <-- browser-sets.inc
new revision: 1.83; previous revision: 1.82
done
Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v <-- browser.js
new revision: 1.731; previous revision: 1.730
done
Checking in browser/base/content/browser.xul;
/cvsroot/mozilla/browser/base/content/browser.xul,v <-- browser.xul
new revision: 1.327; previous revision: 1.326
done
RCS file: /cvsroot/mozilla/browser/base/content/nsContextMenu.js,v
done
Checking in browser/base/content/nsContextMenu.js;
/cvsroot/mozilla/browser/base/content/nsContextMenu.js,v <-- nsContextMenu.js
initial revision: 1.1
done
Checking in browser/base/content/pageInfo.js;
/cvsroot/mozilla/browser/base/content/pageInfo.js,v <-- pageInfo.js
new revision: 1.32; previous revision: 1.31
done
Checking in browser/base/content/web-panels.xul;
/cvsroot/mozilla/browser/base/content/web-panels.xul,v <-- web-panels.xul
new revision: 1.18; previous revision: 1.17
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 6•18 years ago
|
||
Sorry to spam this bug, but could it be related to a display problem of organize bookmarks window (see bug 359361) ?
You need to log in
before you can comment on or make changes to this bug.
Description
•