Closed
Bug 356695
Opened 18 years ago
Closed 17 years ago
Patch for bug 356235 caused a Tp regression on Linux
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: ispiked, Unassigned)
References
Details
(Keywords: perf, regression)
690 MOZ_CO_DATE=2006:10:14:00:08
747 MOZ_CO_DATE=2006:10:14:00:46
Checkins: http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006%3A10%3A14%3A00%3A08%3A00&maxdate=2006%3A10%3A14%3A00%3A46%3A00&cvsroot=%2Fcvsroot
Definitely a regression from bug 356235.
Reporter | ||
Comment 1•18 years ago
|
||
For what it's worth, this patch hurt Linux about as much as it helped Windows (-/+ 0.9%).
Flags: blocking1.9?
Comment 2•18 years ago
|
||
I think that the cache mechanism will win on intl text rendering. On the case we need to itemize and reordering (if Bidi text) the items the string. But maybe it is expensive. So, if we cache the itemizing data, we might get the great performance.
But the ASCII text rendering case is not so...
And I have a question. Should we merge the gfxXftTextRun and the gfxPangoTextRun? If the string doesn't have complex text, we don't need to use itemizing and shaping of pango. And it might be simpler for cache mechanism.
The question is whether this cache will still be useful once textframes keep a pointer to their textrun.
This will probably go away with the new textrun code; also the Tp numebrs seem back to normal even with the cycle collector by now... so this is probably invalid at this point, but it should be easy enough to test.
Flags: blocking1.9? → blocking1.9-
Whiteboard: [wanted-1.9]
This code has drastically changed by now; new textframe should've fixed the issues.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → WORKSFORME
Updated•17 years ago
|
Flags: wanted1.9+
Whiteboard: [wanted-1.9]
You need to log in
before you can comment on or make changes to this bug.
Description
•