The namespace of the attributes isn't handled for example in HasAttributeDependentStyle. I'd like to change this, so that implementing xml:id and DOM 3 setIdAttribute* efficiently would be a bit simpler.

Basically just adding PRInt32 aNamespaceID parameter to few methods and using it whenever using aAttribute parameter too. The changes to nsCSSFrameConstructor.cpp fixes two other cases when namespaced attributes might not be handled properly.

HasAttributeDependentStyle is just an optimization. Are there really enough cases where pages use multiple attributes of the same name to make the extra code worthwhile?

smaug, I have no idea when I would be able to get to this review. :(

I'll make some tests to see how much this improves the performance when there are multiple IDs.

Smaug, got any test results here?

I included this as a part of the current xml:id patch. namespaces are needed there anyway and calls like GetIDAttributeName will be namespace aware.

Want to mark the dep?