Mark Banner (:standard8) Reporter
	Description • 18 years ago

I'm filing this here as that's where the original bug that implemented browser.warnOnAboutConfig was (bug 339720).

Using the following method causes the state of browser.warnOnAboutConfig to be forgotten:

1) Bring up about:config
2) uncheck "Show this warning next time"
3) submit -> config screen displayed.
4) New tab or window
5) bring up about:config again, config screen is displayed straight away.
6) New tab or window
7) bring up about:config again, the warning screen is displayed instead of the config screen.

At step 5) browser.warnOnAboutConfig is reset to true, I think this will also happen with restarting the app.

I think this section is the problem:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpfe/global/resources/content/config.js&rev=1.27&mark=368-372#335

as its assuming that showWarningNextTime has been set to the preference value but the xul always initialises it to true:

http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/config.xul#86

	Andrew Schultz
	Comment 1 • 18 years ago

dumping in SeaMonkey since FF doesn't have this bug (yet :)) and so we get SeaMonkey flags.

	Andrew Schultz
	Comment 2 • 18 years ago

This should block beta (it'd be nice to get the fixed solution tested) if not final.

	neil@parkwaycc.co.uk Assignee
	Comment 3 • 18 years ago

Yeah, the code might as well unconditionally set the pref at that point.

	Chris Thomas (CTho) [formerly cst@andrew.cmu.edu cst@yecc.com]
	Comment 4 • 18 years ago

I understand now.  It's not at all related to having about:config open at the same time in multiple places.  Patch in a few minutes.

	Chris Thomas (CTho) [formerly cst@andrew.cmu.edu cst@yecc.com]
	Comment 5 • 18 years ago

I could have done this another way, but this keeps all callees as just one simple line and doesn't add any new one-line functions.  Not setting "sr?" because I don't think this patch requires it.

	Chris Thomas (CTho) [formerly cst@andrew.cmu.edu cst@yecc.com]
	Comment 7 • 18 years ago

Comment on attachment 242619 [details] [diff] [review]
What I said, but fixed ;-)

Oh.  Because you can't actually check the box once it's been unchecked.  Ok :)

	neil@parkwaycc.co.uk Assignee
	Comment 8 • 18 years ago

Fix checked in to trunk.

	Chris Thomas (CTho) [formerly cst@andrew.cmu.edu cst@yecc.com]
	Comment 9 • 18 years ago

Comment on attachment 242619 [details] [diff] [review]
What I said, but fixed ;-)

Neil landed with a=me.