Closed Bug 359479 Opened 18 years ago Closed 18 years ago

Remote Images in iframes bypass remote content blocker

Categories

(Thunderbird :: Mail Window Front End, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird2.0

People

(Reporter: mscott, Assigned: mscott)

Details

(Keywords: fixed1.8.1.1, privacy, Whiteboard: [sg:low] web bugs)

Attachments

(2 files)

Remote images inside iframes (or nested iframes) bypass mail's remote content blocker. Assuming remote content white listing by address book is turned off, send yourself a message with the following body: <iframe src="http://espn.com"/> When you read the message in Thunderbird 1.5.x and Thunderbird 2.x you should see the remote images load.
Note: 1.5.0.x and 2.x always load the remote images. Trunk builds block remote images because the patch landed for Bug 330443 is aggressive about denying the load in the case of unexpected errors. However, it's too aggressive as it also blocks remote content for RSS articles (Bug 359402). And it doesn't show the blocked remote content bar in the message pane.
Status: NEW → ASSIGNED
Attached patch the fix (deleted) — Splinter Review
In the case of an iframe, aRequestingLocation is going to be the src of the iframe and not the mail url for the message we are showing in the message pane. We care about the mail url because we use that to differentiate between RSS articles and messages (we allow remote images in RSS feeds). I added a routine to get the uri for the message pane and use it as the requesting location if it exists. This makes the thunderbird 2 branch build block remote images in iframes for non RSS articles. It makes the trunk builds show the remote content bar for non rss articles (the content was already getting blocked on the trunk). It also fixes 359402 for the trunk because we can now tell the difference between rss articles and messages again since we pass in the mailnews url to MailShouldLoad.
Attachment #244653 - Flags: superreview?(bienvenu)
Attachment #244653 - Flags: superreview?(bienvenu) → superreview+
We may end up having to adjust this later to make it less restrictive since with this patch we're going to end up denying remote content in non mailnews chrome windows. But I'd rather us be over agressive right now and adjust as things come up. This is now fixed on the trunk and I will land it on the 1.8.1 branch along with 330443.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Attachment #244653 - Flags: approval-thunderbird2+
This needs to be fixed on 1.8.1 now that bug 330443 landed there to prevent bug 359402, right?
Flags: blocking1.8.1.1?
this patch landed along with Bug 330443 on the 1.8.1.1 branch for thunderbird and will be in beta 1.
Keywords: fixed1.8.1.1
Flags: blocking1.8.1.1?
Keywords: privacy
Whiteboard: [sg:low] web bugs
Group: security
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: