Closed Bug 359845 Opened 18 years ago Closed 17 years ago

Crash [@ nsXULTreeitemAccessibleWrap::GetRole] probably !mColumn

Categories

(Core :: Disability Access APIs, defect)

x86
All
defect
Not set
critical

Tracking

()

VERIFIED FIXED

People

(Reporter: timeless, Assigned: surkov)

References

()

Details

(Keywords: crash, testcase, topcrash)

Crash Data

Attachments

(3 files)

Incident ID: 25372706 Stack Signature nsXULTreeitemAccessibleWrap::GetRole 705e62f1 Product ID SunbirdTrunk Build ID 2006100618 Trigger Time 2006-11-01 15:10:00.0 Platform Win32 Operating System Windows NT 5.1 build 2600 Module sunbird.exe + (0041459f) URL visited User Comments Since Last Crash 1077 sec Total Uptime 22566 sec Trigger Reason Access violation Source File, Line No. d:\builds\tinderbox\sunbird-trunk\winnt_5.2_depend\mozilla\accessible\src\msaa\nsxultreeaccessiblewrap.cpp, line 88 Stack Trace nsXULTreeitemAccessibleWrap::GetRole [mozilla\accessible\src\msaa\nsxultreeaccessiblewrap.cpp, line 88] nsAccessibleWrap::MustPrune [mozilla\accessible\src\msaa\nsaccessiblewrap.h, line 199] nsAccessibleWrap::get_accChildCount [mozilla\accessible\src\msaa\nsaccessiblewrap.cpp, line 231] jhook.dll + 0x4ccf (0x15004ccf) jhook.dll + 0x48af (0x150048af) jhook.dll + 0xc177 (0x1500c177) jhook.dll + 0x70a7 (0x150070a7) USER32.dll + 0x4902c (0x77d8902c) ntdll.dll + 0xeae3 (0x7c90eae3) nsAccessible::FireToolkitEvent [mozilla\accessible\src\base\nsaccessible.cpp, line 1763] nsRootAccessible::HandleEventWithTarget [mozilla\accessible\src\base\nsrootaccessible.cpp, line 783] nsSprocketLayout::PopulateBoxSizes [mozilla\layout\xul\base\src\nssprocketlayout.cpp, line 875] 0x50010000 0x300202a7 this is a sunbird topcrash ;-)
OS: SunOS → Windows Server 2003
Attached file testcase for branch builds (deleted) —
This is a testcase that crashes Mozilla with this stacktrace when clicking on the up arrow of the scrollbar. You need to download it to your computer, because of the use of enhanced privileges. It also seems to crash branch builds.
Keywords: testcase
Attached file testcase (deleted) —
Aaron changed something in bug 268935 that makes the original testcase not work anymore in current trunk builds. This is the updated testcase, using nsIAccessibleRetrieval.
Attachment #264990 - Attachment is obsolete: true
WFM, trunk and 1.8 branch builds on Linux.
Attachment #264990 - Attachment description: testcase → testcase for branch builds
Attachment #264990 - Attachment is obsolete: false
According to talkback, there are still crashes @ nsXULTreeitemAccessibleWrap::GetRole
It can crash on Linux at nsXULTreeitemAccessible::GetAccessibleRelated 968 if (NS_SUCCEEDED(mColumn->GetIndex(&columnIndex)) && columnIndex == 0) {
OS: Windows Server 2003 → All
Assignee: aaronleventhal → ginn.chen
Summary: [@ nsXULTreeitemAccessibleWrap::GetRole] probably !mColumn → Crash [@ nsXULTreeitemAccessibleWrap::GetRole] probably !mColumn
Attached patch patch (deleted) — Splinter Review
do not create accessibles for such trees though treeitems are visible but their text doesn't rendered. I think nobody will use these trees so we can skip their support in ally.
Assignee: ginn.chen → surkov.alexander
Status: NEW → ASSIGNED
Attachment #280998 - Flags: review?(Evan.Yan)
Blocks: fox3access
Attachment #280998 - Flags: review?(Evan.Yan) → review+
Attachment #280998 - Flags: approval1.9?
Attachment #280998 - Flags: approval1.9? → approval1.9+
checked in
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Thanks, verified fixed, using: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007091904 Minefield/3.0a8pre Should the patch be considered for branch, since this was/is a topcrasher?
Status: RESOLVED → VERIFIED
(In reply to comment #8) > Should the patch be considered for branch, since this was/is a topcrasher? > I can't reproduce on latest seamonkey 1.8 your testcase for branch builds though problem can exists.
Attachment #280998 - Flags: approval1.8.1.8?
Comment on attachment 280998 [details] [diff] [review] patch This crash does not currently show up in the topcrash list for FF2, we're a bit nervous approving unnecessary changes if we're not fixing a demonstrable problem. If you think this decision is wrong you can renominate with an explanation of the benefit-risk tradeoff.
Attachment #280998 - Flags: approval1.8.1.8? → approval1.8.1.8-
Crash Signature: [@ nsXULTreeitemAccessibleWrap::GetRole]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: