Closed
Bug 360473
Opened 18 years ago
Closed 18 years ago
Need some minor code removal in tabbrowser.xml
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
INVALID
People
(Reporter: u88484, Unassigned)
References
()
Details
While making an extension and browsing through some source code, seen a comment about a bandaid to work around bug 343585. Decided to read the bug and seen it was fixed so I believe the workaround bandaid could be removed.
http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/tabbrowser.xml#773
http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/tabbrowser.xml#1235
http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/tabbrowser.xml#2515
http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/tabbrowser.xml#2524
http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/tabbrowser.xml#2523
http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/tabbrowser.xml#2603
http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/tabbrowser.xml#2611
http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/tabbrowser.xml#2620
http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/tabbrowser.xml#3136
Also found some other code for another bug though in tabbbrowser.xml. I think bugs should be filed if a bandaid is applied because of a bug so that code can be removed along with the patch for the bug. How come that isn't a requirement?
Comment 1•18 years ago
|
||
What exactly makes you think these "bandaids" are no longer needed?
* the workaround for bug 343585 is required until bug 345399 is fixed.
* the workaround for bug 343628 is due to bug 91337.
* the workaround for bug 346035 probably isn't necessary anymore, reopen that bug please.
* bug 346307 is a duplicate.
* The patch on bug 348183 may be the right thing, see bug 348357 (which is still open).
You need to log in
before you can comment on or make changes to this bug.
Description
•