Closed Bug 360474 Opened 18 years ago Closed 17 years ago

Need some minor code removal in globalBindings.xml

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 346931

People

(Reporter: u88484, Unassigned)

References

()

Details

While making an extension and browsing through some source code, seen a comment about a bandaid to work around bugs #346307 and #346035. Decided to read the bug and seen they were fixed so I believe the workaround bandaid could be removed. http://lxr.mozilla.org/mozilla/source/toolkit/themes/winstripe/global/globalBindings.xml#111 http://lxr.mozilla.org/mozilla/source/toolkit/themes/winstripe/global/globalBindings.xml#121 http://lxr.mozilla.org/mozilla/source/toolkit/themes/winstripe/global/globalBindings.xml#130 http://lxr.mozilla.org/mozilla/source/toolkit/themes/pinstripe/global/globalBindings.xml#63 http://lxr.mozilla.org/mozilla/source/toolkit/themes/pinstripe/global/globalBindings.xml#72 http://lxr.mozilla.org/mozilla/source/toolkit/themes/pinstripe/global/globalBindings.xml#81 Also found some other code for another bug though in tabbbrowser.xml. I think bugs should be filed if a bandaid is applied because of a bug so that code can be removed along with the patch for the bug. How come that isn't a requirement?
In bug 346931 there is a patch that already fixes the pinstripe part, I guess that patch could be updated to also remove the code in the winstripe part. That would mean this is a duplicate of bug 346931.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.