tbird trunk 20061112 linux quota status bar item is too tall; switching between an account that shows the quota indicator and one that does not causes the statusbar height to change. (by 1px here)

also, the bright red is a bit garish imo :) this patch uses colors with opacity and without the shadow effect in the hopes that the underlying theme colors bring enough contrast to the table. it seems to look neater on the few themes I looked at. if you opt to not go with this approach, negative margins might do the trick to fix the issue in the summary w/o further appearance changes.

Comment on attachment 245575 [details] [diff] [review] bring on the bikeshed I like this change a lot. I'd like to let BenB comment as well though.

> the bright red is a bit garish imo :) The red is intentionally strong. Given that this appears only when the user is at 95% quota, meaning that he has to *take immediate action*, I think it's actually quite subtle as-is. Compare this to the continuous popup warning dialogs that Thunderbird currently passes me on from the server in the same situation. I don't think the faint red is appropriate in such a situation. Similarily, the 80-94% are a quite severe situation, too, esp. if the quota is 20 MB. Yes, the shadow is mainly for the contrast (but I think it looks nice, too). I actually wanted to make it part of the <progressmeter>. That approach would fix this bug, too, I think. There are probably other workarounds than removing the shadow, e.g. the negative margins Tuukka mentioned in comment 1? Note that making the colors softer doesn't garantee contrast, as the forground color is arbitrary and the background fixed.

From a UI / aethetics point of view, I'd like to take this patch. I've looked at the before and after and feel the patch makes this cool feature even better. I'd like to convince BenB this is the case too before I step in though :)

Comment on attachment 245575 [details] [diff] [review] bring on the bikeshed I don't want this to miss the beta2 train, let's get this in. Tuukka, can you land this or do you need help?

no, I can't; go ahead

Sorry (!) for my lack of reply so far. Check it in, if you want.

Same patch, but with no opaque. Reason shown in screenshot (following).

Screenshot shows 1. before (bug 278096 without changes) 2. Tuukka's patch (v1) 3. My last patch (v2) When applying and testing the patch by Tuukka, the result was not as shown in his attached screenshot, but the native progressmeter was still there, with 0%, and opacity applied to the text. Removing opaque fixed it. mscott, should we go with that?

hmm, at least on the trunk, I'm not seeing the native progressmeter you are seeing in the screen shot. I wonder if that problem is branch only.

Could be Linux-only, too. I'll build trunk to see whether I see it there.

Comment on attachment 251553 [details] [diff] [review] Fix, v2, branch Let's go with this for now then.

Thanks. Checked v2 into MOZILLA_1_8_BRANCH. *Not* in trunk yet.

I see the same problem on trunk Linux.

Exact same results as in screenshot on trunk. Checked into trunk as well, assuming your reviews were applicable for the trunk as well.

FIXED

hmm, I'm curious about what gtk/theme you got the issue in attachment 251554 [details] with, I don't see it on 2.10.6 with the 23 themes I have on edgy on trunk or branch

SuSE 10.1 X86-64 gtk 1.2.10 + 2.8.10 default theme mozconfig (trunk): . $topsrcdir/mail/config/mozconfig ac_add_options --disable-profilesharing ac_add_options --disable-updater ac_add_options --disable-oji ac_add_options --disable-gnome-vfs ac_add_options --enable-optimize=-O ac_add_options --disable-debug ac_add_options --disable-tests ac_add_options --enable-static --disable-shared ac_add_options --enable-extensions=default,inspector ac_add_options --disable-svg

This bug causes bug 385175 (see comment 4 here).