Closed
Bug 361191
Opened 18 years ago
Closed 18 years ago
In suiterunner preferences once Mail & Newsgroups -> Tags pane is selected you can't get out of it.
Categories
(SeaMonkey :: Preferences, defect)
SeaMonkey
Preferences
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
(deleted),
patch
|
iannbugzilla
:
review-
|
Details | Diff | Splinter Review |
On suiterunner builds go into preferences and Select Mail & Newsgroups, followed by Tags. Then try to select another pane - it doesn't change, the console comes up with: JavaScript error: chrome://messenger/content/pref-labels.js, line 90: aPageData has no properties
Assignee | ||
Updated•18 years ago
|
Summary: In suiterunner preferences once Mail & Newsgroups -> Tags pane is selected you can't get off it. → In suiterunner preferences once Mail & Newsgroups -> Tags pane is selected you can't get of it.
Updated•18 years ago
|
Summary: In suiterunner preferences once Mail & Newsgroups -> Tags pane is selected you can't get of it. → In suiterunner preferences once Mail & Newsgroups -> Tags pane is selected you can't get out of it.
Assignee | ||
Comment 1•18 years ago
|
||
This seems to be due to http://lxr.mozilla.org/seamonkey/source/mailnews/base/prefs/resources/content/pref-labels.js#296 I think: var pageData = parent.hPrefWindow.wsm.dataManager.pageData[TAGPANEL_URI]; should be: var pageData = parent.hPrefWindow.wsm.dataManager.getPageData(TAGPANEL_URI); based on https://bugzilla.mozilla.org/attachment.cgi?id=227764 but I won't have a build available to me until later to try this on.
Assignee | ||
Comment 3•18 years ago
|
||
This fixes the problem. Just need to check for regressions on xpfe.
Assignee | ||
Comment 4•18 years ago
|
||
Comment on attachment 246053 [details] [diff] [review] Possible fix This seems to work ok in both xpfe & toolkit suiterunner, requesting reviews.
Attachment #246053 -
Flags: review?(iann_bugzilla)
Comment on attachment 246053 [details] [diff] [review] Possible fix I would expect there to be the same problem with pref-cache.xul and possibly pref-fonts.js in suiterunner. Might be worth removing dataObject from GetFields in http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/nsWidgetStateManager.js#168 too
Attachment #246053 -
Flags: review?(iann_bugzilla) → review-
Assignee | ||
Comment 6•18 years ago
|
||
(In reply to comment #5) > (From update of attachment 246053 [details] [diff] [review] [edit]) > I would expect there to be the same problem with pref-cache.xul and possibly > pref-fonts.js in suiterunner. Might be worth removing dataObject from GetFields > in > http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/nsWidgetStateManager.js#168 > too There is a problem with pref-cache.xul, I tried a similar fix but for some reason couldn't get it to work. pref-fonts.js I hadn't picked up on a problem, but I may have missed that. I'll have to have another look.
Assignee | ||
Comment 7•18 years ago
|
||
The SeaMonkey patch on bug 374404 that I've just committed has fixed this as we now use xpfe's wsm for suiterunner rather than toolkit's.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•