Stylesheets specified as style lines in chrome manifest files rather than as xml pi's are no longer applied to the document. Regression range is 2006111104 to 2006111204 http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1163246341&maxdate=1163336280 Choosing to blame bug 319654

We shouldn't ship alpha1 with this, IMO.

I'm looking into it. My debug builds don't have this problem, will have to do a clean debug build and an opt build.

Dave, do you have particular steps to reproduce? Is a particular extension involved?

Discovered that this only occurs when the xul cache is disabled, so possibly not so much of a problem. Opening the customize toolbar dialog should demonstrate the problem, most of the items are without their icons.

Duh.

Comment on attachment 246353 [details] [diff] [review] patch I meant to do this when I removed the loading code from EndLoad. The fact that I don't remove the IsChromeURI check does mean that non chrome sheets from the chrome registry won't get loaded, like I guess they used to. I think it's ok, since they were never handled well by the old code (which didn't add them to prototype's sheets).

Need to document the change comment 6 describes.

Comment on attachment 246353 [details] [diff] [review] patch Makes sense. r+sr=bzbarsky

mozilla/content/xul/document/src/nsXULDocument.cpp 1.741

I'm unclear on what needs documenting here. It looks like a one-line change that fixes a bug; is it something that people actually need specifically documented? I'm just not sure where it would go.

Added the note I think appropriate at http://developer.mozilla.org/en/docs/Chrome_Registration#style

That's correct.(In reply to comment #11) > Added the note I think appropriate at > http://developer.mozilla.org/en/docs/Chrome_Registration#style > Thanks, that's the note that should have been added.