Closed Bug 361523 Opened 18 years ago Closed 18 years ago

[Cairo / Cocoa] All borders not at pixel boundaries are a pixel too thick

Categories

(Core :: Graphics, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: hwaara, Unassigned)

References

Details

(Keywords: regression)

Attachments

(3 files)

After the switch to cairo, the inset on form controls' borders are extremely thick. Screenshots coming up.
Attached image Before (deleted) —
Before the cairo-switch.
Attached image After (deleted) —
Note that all form controls (buttons, textfields, select menus) have almost doubled their border's thickness.
Attachment #246283 - Attachment is patch: false
Attachment #246283 - Attachment mime type: text/plain → image/png
Radio buttons look better, though. http://quotes.burntelectrons.org/1594
What date was the switch to Cairo? I'm having trouble finding out on Bonsai or Bugzilla.
(In reply to comment #4) > What date was the switch to Cairo? I'm having trouble finding out on Bonsai or > Bugzilla. Sorry, never mind. I don't know how I missed bug 323934, checked in 2006-11-21 16:58.
Blocks: 334729
Flags: blocking1.9?
*** Bug 363686 has been marked as a duplicate of this bug. ***
Flags: blocking1.9? → blocking1.9+
What's going on here seems like a cairo bug. Any border that's not aligned to a pixel boundary is getting drawn a pixel too thick. It's nothing specific to form controls. I'll attach a testcase to show this. (It's probably showing up more reliably for vertical borders presumably because vertical coordinates are much more cumulative, and therefore much less likely to be pixel-aligned.)
Summary: [Cairo / Cocoa] Form borders are too thick (even thicker than before) → [Cairo / Cocoa] All borders not at pixel boundaries are a pixel too thick
All the borders in this testcase should be 2px wide, but only 1 out of every 10 is; the rest (not aligned to pixel boundaries) are 3px wide.
It this bug also responsible for making some link underlines appear too close to the link text? Or is that a separate bug?
Separate. Underlines aren't done using FillPolygon, and I think the cause of this bug is a rounding bug in FillPolygon.
see bug 365336 for the underline problem.
Blocks: acid2
This should be fixed by the patch for bug 368247.
Status: NEW → RESOLVED
Closed: 18 years ago
Depends on: 368247
Resolution: --- → FIXED
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: