Pavel Cvrcek [:JasnaPaka] Reporter
	Description • 18 years ago

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; cs; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061122 Minefield/3.0a1

This isn't dupe of bug #342143. On some sites there is still problem with incorrectly substitutes fonts.

Problematic sites:
* http://www.cdr.cz/
* http://aktualne.centrum.cz/

Reproducible: Always

	Pavel Cvrcek [:JasnaPaka] Reporter
	Comment 1 • 18 years ago

First font (Arial) i have installed but not second (Arial CE) and there is a problem for me.

	Masatoshi Kimura [:emk]
	Comment 2 • 18 years ago

Both of Fx 2 and trunk displayed the same result for me.
Please submit a screenshot.
What result are you expected? What is an actual result?

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 4 • 18 years ago

I found bug 361529 that means current resolver for win doesn't work fine.
Can you check the patch?

# I cannot reproduce this too.

	Masatoshi Kimura [:emk]
	Comment 5 • 18 years ago

Probably bug 361529 will also fix this.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 6 • 18 years ago

bug 361529 was fixed, please recheck the testcase with next nightly build.

	Justin Kerk
	Comment 7 • 18 years ago

I can reproduce this.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061122 Minefield/3.0a1 ID:2006112204 [cairo]

	Pavel Cvrcek [:JasnaPaka] Reporter
	Comment 8 • 18 years ago

(In reply to comment #6)
> bug 361529 was fixed, please recheck the testcase with next nightly build.

Same result with today build.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 9 • 18 years ago

On WinXP-ja, this bug is not reproduced. What's your environment?
Didn't install third-party fonts?

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 10 • 18 years ago

Looks like the "Webdings" is used for 'a'...

	TBO EMC
	Comment 11 • 18 years ago

(In reply to comment #10)
> Looks like the "Webdings" is used for 'a'...
> 

It's instead of "Arial CE"
Downloaded latest nightly build (rv:1.9a1) Gecko/20061123 Minefield/3.0a1) and no correction

	TBO EMC
	Comment 12 • 18 years ago

It's a MARLET font...

	Pavel Cvrcek [:JasnaPaka] Reporter
	Comment 13 • 18 years ago

(In reply to comment #9)
> On WinXP-ja, this bug is not reproduced. What's your environment?
> Didn't install third-party fonts?

- Windows XP ENG with Czech regional and language options
- no third-party fonts

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 14 • 18 years ago

Kimura-san found the cause of this bug. But we don't have good way for fixing it yet. I'll try to create the patch.

	Justin Kerk
	Comment 15 • 18 years ago

(In reply to comment #10)
> Looks like the "Webdings" is used for 'a'...

The font used varies from computer to computer. On his system, it's Marlett (the built-in font used to draw the X button on windows and such), on mine it's Code2000. These same fonts were incorrectly substituted in bug 330715 and bug 342143.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 16 • 18 years ago

This patch may be fixes this bug.

This patch generates the font alias table for FontSubstitute from registry.
This patch is weak for changing the spec of Windows. But this registry information is written in MS TechNet. I think that the spec will not be changed easily.
# http://www.microsoft.com/technet/prodtechnol/windows2000serv/reskit/regentry/11815.mspx?mfr=true

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 17 • 18 years ago

Oops, sorry. The previous patch doesn't have a header file.

	TBO EMC
	Comment 18 • 18 years ago

Soeey for question, but how to implement the patch, how to work it? Do I have to compile my own build of firefox, will be this error corrected in nightly builds?

	TBO EMC
	Comment 19 • 18 years ago

Sorry for question, but how to implement the patch, how to work it? Do I have to compile my own build of firefox, will be this error corrected in nightly builds?

	Justin Kerk
	Comment 20 • 18 years ago

If you want the fix right now, you have to compile your own build of Firefox, instructions on how to do that are at http://developer.mozilla.org/en/docs/Build_Documentation

The fix will most likely be made in the nightly builds as soon as someone can review the patch, so if you can wait until then you don't have to compile yourself.

	Masatoshi Kimura [:emk]
	Comment 21 • 18 years ago

Comment on attachment 246456 [details] [diff] [review]
Patch rv1.0.1

>     nsDataHashtable<nsStringHashKey, nsRefPtr<FontEntry> > mFonts;
>     nsDataHashtable<nsStringHashKey, nsRefPtr<FontEntry> > mFontAliases;
>+    nsDataHashtable<nsStringHashKey, nsRefPtr<FontEntry> > mFontSubstitutes;
Do you have to distinguish mFonts from others?

Please ask a formal reviewer before you check in.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 22 • 18 years ago

Comment on attachment 246456 [details] [diff] [review]
Patch rv1.0.1

(In reply to comment #21)
> (From update of attachment 246456 [details] [diff] [review] [edit])
> >     nsDataHashtable<nsStringHashKey, nsRefPtr<FontEntry> > mFonts;
> >     nsDataHashtable<nsStringHashKey, nsRefPtr<FontEntry> > mFontAliases;
> >+    nsDataHashtable<nsStringHashKey, nsRefPtr<FontEntry> > mFontSubstitutes;
> Do you have to distinguish mFonts from others?

First, thank you for your review and hard testing.

mFonts only store the font list that is used by GetFontList.
But mFontAliases and mFontSubstitutes are not used in different point at now, so, we can merge this two lists. I leave the judgment to formal reviewer, Stuart.

	Simon Montagu :smontagu
	Comment 23 • 18 years ago

The patch also fixes bug 346503.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 24 • 18 years ago

*** Bug 346503 has been marked as a duplicate of this bug. ***

	TBO EMC
	Comment 25 • 18 years ago

Gecko/20061219 Minefield/3.0a2pre
Bug still not repaired - any progress?

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 26 • 18 years ago

The patch is still being reviewed.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 27 • 18 years ago

Stuart:

Would you hurry up to review for this?
The patch has been attached one month ago... This bug blocks my work for Windows.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 28 • 18 years ago

Thank you, Stuart.

checked-in.

	Pavel Cvrcek [:JasnaPaka] Reporter
	Comment 29 • 18 years ago

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20070105 Minefield/3.0a2pre
- can confirm that now all works fine. Thanks.

	tonda kavalec
	Comment 30 • 18 years ago

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20070105
Minefield/3.0a2pre Where can I download it please? I want to test it, one more time.

	Peter van der Woude [:Peter6]
	Comment 31 • 18 years ago

(In reply to comment #30)
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20070105
> Minefield/3.0a2pre Where can I download it please? I want to test it, one more
> time.
> 
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/fx-win32-tbox-trunk/


Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20070105 Minefield/3.0a2pre ID:2007010512 [cairo]

verified/fixed

	tonda kavalec
	Comment 32 • 18 years ago

Thank you, it works correctly!