Closed
Bug 362253
Opened 18 years ago
Closed 15 years ago
Support large files (>= 2GB) on FreeBSD.
Categories
(NSPR :: NSPR, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
4.8.5
People
(Reporter: wtc, Assigned: wtc)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
wtc
:
review+
|
Details | Diff | Splinter Review |
NSPR should support large files (>= 2GB) on FreeBSD.
This requires defining the appropriate macro (_PR_HAVE_LARGE_OFF_T
or _PR_HAVE_OFF64_T) instead of _PR_NO_LARGE_FILES in
mozilla/nsprpub/pr/include/md/_freebsd.h.
|
||
Updated•18 years ago
|
QA Contact: wtchang → nspr
|
||
Comment 2•15 years ago
|
||
FreeBSD should use _PR_HAVE_LARGE_OFF_T because sizeof(off_t) is 8 even if 32-bit system.
|
|
||
Comment 3•15 years ago
|
||
|
|
||
Updated•15 years ago
|
Attachment #427695 -
Flags: review?(wtc)
|
Assignee | |
Comment 4•15 years ago
|
||
Comment on attachment 427695 [details] [diff] [review]
patch
r=wtc. I verified that on FreeBSD 6.3 and 7.0, off_t is 64-bit:
<unistd.h> and <fcntl.h> have:
#ifndef _OFF_T_DECLARED
typedef __off_t off_t;
#define _OFF_T_DECLARED
#endif
<sys/_types.h> has:
typedef __int64_t __off_t; /* file offset */
Attachment #427695 -
Flags: review?(wtc) → review+
|
|
Assignee | |
Comment 5•15 years ago
|
||
I checked in the patch on the NSPR trunk (NSPR 4.8.5).
Checking in _freebsd.h;
/cvsroot/mozilla/nsprpub/pr/include/md/_freebsd.h,v <-- _freebsd.h
new revision: 3.22; previous revision: 3.21
done
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.8.5
You need to log in
before you can comment on or make changes to this bug.
Description
•