Closed
Bug 362567
Opened 18 years ago
Closed 18 years ago
Customize Message Views modal dialog won't go away
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Thunderbird2.0
People
(Reporter: myk, Assigned: mnyromyr)
References
(Blocks 1 open bug)
Details
(Keywords: fixed1.8.1.2, verified1.8.1.3, Whiteboard: [See comment #1 for a workaround])
Attachments
(1 obsolete file)
The Customize Message Views modal dialog (View dropdown > Customize...) reappears every time I try to dismiss it by clicking the OK button, clicking the window close box, or pressing the escape key. And since the dialog is modal, it prevents me from accessing the main Thunderbird window.
As a result, once I open that dialog I am no longer able to use Thunderbird, and I can't even quit it from within the application.
I'm seeing this behavior in the latest nightly (20061201) of 2.0 beta 1 for Linux. I haven't tested other platforms or previous nightlies.
Reporter | ||
Comment 1•18 years ago
|
||
Workaround: select an item from the list, then press OK. The dialog will go away and won't reappear. But the View will change to the item you selected (a separate bug?).
Comment 3•18 years ago
|
||
I see this too. There aren't any erorrs in the JS console either.
Flags: blocking-thunderbird2+
Target Milestone: --- → Thunderbird2.0
Comment 4•18 years ago
|
||
I think this might be related to 349991
Comment 5•18 years ago
|
||
If you don't select a view in the customie view list dialog before you hit ok, then the call back in msgViewPickerOverlay.js seems to get unhappy, and we re-open the customize view dialog.
Assignee | ||
Comment 7•18 years ago
|
||
> If you don't select a view in the customie view list dialog before you hit ok,
> then the call back in msgViewPickerOverlay.js seems to get unhappy, and we
> re-open the customize view dialog.
Woo, that reopening is quite a coincidence. ;-)
The list returns -1 as the selected index and so we select the first index *before* the custom views which incidentally happens to be Customize... again.
Assignee: mscott → mnyromyr
Assignee | ||
Comment 8•18 years ago
|
||
Try to change view when returning the customize dialog only if one was selected and the dialog wasn't cancelled.
(Patch is against 1.8 branch, but should apply to trunk also.)
Attachment #247719 -
Flags: superreview?(bienvenu)
Attachment #247719 -
Flags: review?
Assignee | ||
Updated•18 years ago
|
Attachment #247719 -
Flags: review? → review?(neil)
Assignee | ||
Comment 9•18 years ago
|
||
If bug 362990 drops the view selection change, this bug here is irrelevant. Marking dependency.
Depends on: 362990
Comment 10•18 years ago
|
||
Comment on attachment 247719 [details] [diff] [review]
skip some selection tries
I happened to notice an unrelated bug while testing this: when selecting Customise or Save for the first time then the picker label is blanked.
Attachment #247719 -
Flags: review?(neil) → review+
Assignee | ||
Comment 11•18 years ago
|
||
> I happened to notice an unrelated bug while testing this: when selecting
> Customise or Save for the first time then the picker label is blanked.
I'll have a look at that while hunting down bug 362656 comment 0 point 3.
Updated•18 years ago
|
Attachment #247719 -
Flags: superreview?(bienvenu) → superreview+
Assignee | ||
Comment 12•18 years ago
|
||
> I happened to notice an unrelated bug while testing this: when selecting
> Customise or Save for the first time then the picker label is blanked.
That's another fallout of the early return in ViewChange, and I think we're going to kill it in bug 362741 (unless yet unthought cruel monsters turn up from under the bed).
Assignee | ||
Comment 13•18 years ago
|
||
Comment on attachment 247719 [details] [diff] [review]
skip some selection tries
Asking for approval to get the bug fixed on branch and avoid SM shipping with it.
Attachment #247719 -
Flags: approval-thunderbird2?
Assignee | ||
Updated•18 years ago
|
Whiteboard: [See comment #1 for a workaround]
Comment 14•18 years ago
|
||
Sounds good to me, a=me for SeaMonkey 1.1 (no appropriate flag here)
Assignee | ||
Comment 15•18 years ago
|
||
Fixed by bug 362990.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•18 years ago
|
Attachment #247719 -
Attachment is obsolete: true
Attachment #247719 -
Flags: approval-thunderbird2?
Updated•18 years ago
|
Keywords: fixed1.8.1.2
Comment 16•18 years ago
|
||
verified fixed1.8.1.3 using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 ID:2007032620, tested with the steps to reproduce from this bug.
Keywords: verified1.8.1.3
Updated•18 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•