Closed
Bug 363089
Opened 18 years ago
Closed 17 years ago
Remove nsIDOMEventReceiver
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
After bug 363067, nsIDOMEventReceiver could be merged to nsPIDOMEventTarget.
Assignee | ||
Comment 1•18 years ago
|
||
Actually, nsIDOMEventReceiver can be just removed and use nsIEventListenerManager when really needed.
Assignee | ||
Comment 2•18 years ago
|
||
WIP patch containing also bug 363067 is here http://www.cs.helsinki.fi/u/pettay/moztests/events/remove_nsidomeventreceiver.diff
Assignee | ||
Comment 3•18 years ago
|
||
http://www.cs.helsinki.fi/u/pettay/moztests/events/remove_nsidomeventreceiver.diff should remove now all uses of nsIDOMEventReceiver. And it even compiles (ff, tb, sm) :) Waiting for bug 363067.
Assignee | ||
Comment 4•17 years ago
|
||
Assignee | ||
Updated•17 years ago
|
Attachment #262273 -
Attachment is patch: true
Attachment #262273 -
Attachment mime type: text/x-patch → text/plain
Assignee | ||
Updated•17 years ago
|
Attachment #262273 -
Flags: review?(jst)
Comment 5•17 years ago
|
||
Comment on attachment 262273 [details] [diff] [review] v1 - In content/xbl/public/nsIXBLService.h: - NS_IMETHOD AttachGlobalKeyHandler(nsIDOMEventReceiver* aElement)=0; + NS_IMETHOD AttachGlobalKeyHandler(nsPIDOMEventTarget* aTarget)=0; Since you're changing this "interface", you should bump the IID here (even if it's not in IDL). Same for nsPIDOMEventTarget. - In embedding/browser/gtk/src/EmbedPrivate.h: EmbedContentListener *mContentListener; nsCOMPtr<nsISupports> mContentListenerGuard; EmbedEventListener *mEventListener; nsCOMPtr<nsISupports> mEventListenerGuard; nsCOMPtr<nsIWebNavigation> mNavigation; nsCOMPtr<nsISHistory> mSessionHistory; - // our event receiver - nsCOMPtr<nsIDOMEventReceiver> mEventReceiver; + nsCOMPtr<nsPIDOMEventTarget> mEventTarget; Add a space to make member names line up again. r+sr=jst with that.
Attachment #262273 -
Flags: superreview+
Attachment #262273 -
Flags: review?(jst)
Attachment #262273 -
Flags: review+
Assignee | ||
Comment 6•17 years ago
|
||
I'll check this in during next weekend, when there aren't too many other check-ins.
Assignee | ||
Comment 7•17 years ago
|
||
bah, I just checked this in. Hoping not to see to much red in tboxes.
Assignee | ||
Comment 8•17 years ago
|
||
backed out. some chrome and mochitests failed and couldn't immediately see where to problem is.
Assignee | ||
Comment 9•17 years ago
|
||
Attachment #262273 -
Attachment is obsolete: true
Assignee | ||
Updated•17 years ago
|
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 10•17 years ago
|
||
nsIDOMEventTarget occurs still few times in the tree, for example in some comments. I'll post a small patch to remove those.
Assignee | ||
Comment 11•17 years ago
|
||
Things which aren't usually (or ever) compiled. The strange looking part is nsWindowRoot, but those macros don't actually use the second parameter currently.
Attachment #264801 -
Flags: superreview?(jst)
Attachment #264801 -
Flags: review?(jst)
Comment 12•17 years ago
|
||
Comment on attachment 264801 [details] [diff] [review] leftovers r+sr=jst
Attachment #264801 -
Flags: superreview?(jst)
Attachment #264801 -
Flags: superreview+
Attachment #264801 -
Flags: review?(jst)
Attachment #264801 -
Flags: review+
You need to log in
before you can comment on or make changes to this bug.
Description
•