I started to revive my old patch which started to deComtaminate old nsIBox methods (bug 243370), and noticed that I hade started to do some other cleanup in there. That patch will be large enough as it is so I decided to split out the changes for /layout/xul/base/src/grid/. The clean-up soon got out of hand, I'll attached two patches. Not very important code, but since I started I might as well finish it.

Fixed returntypes and some small things along the way. Will make this look like the fixed nsIFrame code once it is fixed. Tested with the gred/examples/ files.

Comment on attachment 248682 [details] [diff] [review] First patch, trivial returntype changes - aSize = 0; - return NS_OK; + nscoord height(0); + return height; Just "return 0;" + if (row->IsCollapsed(aState)) { + nscoord height(0); + return height; + } Ditto - aSize = 0; - return NS_OK; + nscoord height(0); + return height; Ditto

Whoa, review after 13 minutes! :-)

First patch landed by smaug, thanks.

Last patch, more code removal here. I'll follow up this bug by investigating a few old bugs regarding assertions in nsGrid.

Thanks to smaug for landing the second patch as well.