With current 1.1 branch builds, the clear button for the search box is always disabled. When entering a search term, I get two JS exceptions: * Call to xpconnect wrapped JSObject produced this error: * [Exception... "'[JavaScript Error: "gSearchBundle has no properties" {file: "chrome://messenger/content/searchBar.js" line: 105}]' when calling method: [nsIMsgSearchNotify::onNewSearch]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame :: chrome://messenger/content/searchBar.js :: onSearch :: line 346" data: yes] * Call to xpconnect wrapped JSObject produced this error: * [Exception... "'[JavaScript Error: "gSearchBundle has no properties" {file: "chrome://messenger/content/searchBar.js" line: 64}]' when calling method: [nsIMsgSearchNotify::onSearchDone]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "<unknown>" data: yes] backing out bug 362741 made the bug go away. This doesn't seem to be a problem on the trunk.

OS/2 too

WFM on Mozilla/5.0 (X11; U; Linux i686; de-AT; rv:1.8.1.1) Gecko/20061217 SeaMonkey/1.1

Sorry, my fault, wrong window, wrong button. I see the problem with the "Clear" button in the search bar of the main mail window (at least once I turn on that bar). What works for me is the "clear" button in the "search message" window, which is a different beast, of course.

gSearchBundle and gClearBundle are initialized in onEnterInSearchBar - if gSearchInput isn't set yet. But gSearchInput is set in various places, so this condition is not very useful...

OK. trunk doesn't have this problem because I robustified it (differently) in bug 286367. Should we do that instead on branch or do this on trunk?

Since we don't want to check each four globals each time just to be sure, I think we should go for the event listener on both trunk and branch. Supposing Neil agrees. ;-)

Comment on attachment 248945 [details] [diff] [review] init globals on startup Sorry, but I prefer ajschult's patch.

fixed-by-286367 on branch leaving open for a better fix on trunk

still broken in Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.8.1.1) Gecko/20061223 SeaMonkey/1.1

The patch for bug 286367 is not in Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.8.1.1) Gecko/20061223 SeaMonkey/1.1. I edited into my installation's messenger.jar the change in that patch and now the clear button works as expected.

According to the CVS log (http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/mailnews/base/resources/content/searchBar.js&rev=1.42.4.5) the patch was checked in...maybe try a clobber?

For me it's fixed on Linux

Karsten, Are you still working on this ?

See comment #8, but low priority.

Closing. This bug does not exist on trunk since we moved to textbox type="search" which eliminated the need for separate [clear] buttons.