Phil Ringnalda (:philor) Reporter
	Description • 18 years ago

Because XUL hates us (bug 251273, bug 215489, bug 220701), we persist the currentset for customized toolbars as attributes on a toolbarset, so that if the toolbar named "foopy" has one element named "goats" on it, we persist |toolbar12345="foopy:goats"|, and then in the toolbar binding we recreate the toolbar with .split(":") and call [0] the name, and [1] the currentset.

That's fine until someone creates a toolbar named "foopy:goats", and then puts the perfectly legally named "<toolbarbutton id="foopy:goats">" button on it, when we'll persist |toolbar1234="foopy:goats:foopy:goats"| and then try to recreate a toolbar named "foopy" and put the element with id="goats" on it. If not for id="foopy:goats", we could .split(":"), pop(), join(":"), to call everything after the last colon the currentset, and everything before the name, but since we can't obscurely break perfectly legal XML, we need to tell the user "No! That's a bad, bad name."

	Phil Ringnalda (:philor) Reporter
	Comment 2 • 17 years ago

Gavin: do you remember anything we said, when we talked about this in Decemberish? I vaguely remember "the horror, the horror" and not having the feeling that it would be cheap to migrate to something nicer, but that's about it.

	:Gavin Sharp [email: gavin@gavinsharp.com]
	Comment 3 • 17 years ago

I don't remember anything specific other than the general ickiness I still feel now as I read the patch. Can we just silently strip out colons?

	Phil Ringnalda (:philor) Reporter
	Comment 4 • 17 years ago

Sure, silently stripping them is much easier. I'll get around to looking at how to testcase this, erm, sometime.

	Phil Ringnalda (:philor) Reporter
	Comment 5 • 17 years ago

Though I notice looking at it now, that our behavior when you have an existing toolbar named Foobar, and you try to create Foo:bar, would be exactly the sort of thing that reasonably enrages users.