Open Bug 364693 Opened 18 years ago Updated 5 years ago

replace "make all" with "convert ..."

Categories

(Bugzilla :: Installation & Upgrading, defect, P4)

Product:
Bugzilla
Component:
Installation & Upgrading
Version:
2.23.3
Type:
defect

Tracking

()

People

(Reporter: timeless, Assigned: shrey2809)

Details

(Keywords: ue)

Attachments

(2 files)

reorder and clarify warnings
(deleted), patch
mkanat
: review-
Details | Diff | Splinter Review
GitHub Pull Request
(deleted), text/x-github-pull-request
Details
steps: 1. watch justdave run checksetup.pl actual results: ... and run contrib/recode.pl to make all the data in your database into UTF-8. expected results: use the word 'convert' instead of 'make' (or maybe 'make sure all the data in your database is encoded as UTF-8')
Severity: enhancement → trivial
OS: Windows XP → All
Priority: -- → P4
Hardware: PC → All
Attached patch reorder and clarify warnings (deleted) — — Splinter Review
Assignee: installation → timeless
Status: NEW → ASSIGNED
Attachment #276391 - Flags: review?(justdave)
Max should be the one reviewing this patch.
Attachment #276391 - Flags: review?(justdave) → review?(mkanat)
Comment on attachment 276391 [details] [diff] [review] reorder and clarify warnings The "this will affect every single table" applies both to the UTF-8 conversation and to recode.
Attachment #276391 - Flags: review?(mkanat) → review-
Assignee: timeless → installation
Status: ASSIGNED → NEW
Bug still present, but now in template/en/default/setup/strings.txt.pl . Gerv
Whiteboard: [good first bug]
:gerv- is this still a worthwhile bug to fix? If so, and if this makes a good first bug, can you link to the code, how to reproduce this problem, and what an ideal fix looks like? This should have a mentor assigned as well.
Flags: needinfo?(gerv)
Code file given in comment 4; this is just a typo fix. It doesn't need a mentor. Gerv
Flags: needinfo?(gerv)
No longer blocks: 1126453
Hi , Is this still a valid bug ? how do I go about resolving it? (PS. its my first time here)
Flags: needinfo?(installation)
:gerv, can you help Shrvan find the code, get setup, and determine how to post a patch. I know you said this bug didn't need a mentor, but someone has to help point Shrvan in the right direction.
Flags: needinfo?(installation) → needinfo?(gerv)
(In reply to Joel Maher ( :jmaher) from comment #8) > :gerv, can you help Shrvan find the code See bug 364693 comment 6. > get setup See https://bugzilla.readthedocs.io/en/latest/installing/ and https://github.com/bugzilla/bugzilla > and determine how to post a patch. See https://wiki.mozilla.org/Bugzilla:Developers
Flags: needinfo?(gerv)
(In reply to shrvan from comment #7) > Hi , Is this still a valid bug ? how do I go about resolving it? (PS. its my > first time here) Hey shrvan! The easiest way to get setup would be to get our code from github (https://github.com/bugzilla/bugzilla) and follow along the readme to get a local copy running: https://github.com/bugzilla/bugzilla/blob/master/README.rst#for-developers Meanwhile, I'm not sure about this bug. The topic is different from the applied patch, and I don't know if it is still valid but I'll triage and get back to you shortly.

Removing good-first-bug keyword because team does not have bandwidth to mentor at the moment.

Keywords: good-first-bug

Hi, I would like to start contributing. This is my first bug so can you please guide me on how to fix this bug. Thanks

Welcome Shrey and thanks a lot for your interest! Do you have a specific question which is not already answered by previous comments?

Is this bug in the mozilla-firefox build or do I have to separately set up the bugzilla developer build?

Sir, I have corrected the bug and sent a pull request. Kindly verify and let me know it there is any problem. Thank you

Has this bug been resolved?

Whiteboard: [good first bug]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: