Closed
Bug 365394
Opened 18 years ago
Closed 18 years ago
Address bar no longer focused when closing the last tab
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: zeniko, Assigned: zeniko)
Details
(Keywords: regression, verified1.8.1.2)
Attachments
(1 file)
(deleted),
patch
|
asaf
:
review+
mconnor
:
ui-review+
jay
:
approval1.8.1.2+
|
Details | Diff | Splinter Review |
Regression due to the back-out in bug 348031.
Steps to reproduce:
1. Make the tab bar visible all the time
2. Close all open tabs through either Ctrl+W or the tabs' close buttons
Expected result:
A blank tab is shown and the address bar has the focus (as after creating a new tab).
Actual result:
The content area has the focus.
Flags: blocking1.8.1.2?
Assignee | ||
Comment 1•18 years ago
|
||
Updated•18 years ago
|
Flags: blocking1.8.1.2? → blocking1.8.1.2+
Comment 2•18 years ago
|
||
Please get this patch reviewed and thoroughly tested before asking for approvals (to avoid repeating what happened in bug 348031). Thanks!
Updated•18 years ago
|
Whiteboard: need r=mano
Comment 3•18 years ago
|
||
Comment on attachment 249989 [details] [diff] [review]
branch patch
r=mano.
Attachment #249989 -
Flags: review?(mano) → review+
Comment 4•18 years ago
|
||
Simon: Do we need any input from beltzner or mconnor before landing this? Please check with them before requesting branch patch approvals. Thanks!
Assignee | ||
Updated•18 years ago
|
Attachment #249989 -
Flags: ui-review?(beltzner)
Comment 5•18 years ago
|
||
Comment on attachment 249989 [details] [diff] [review]
branch patch
We should get this before freeze
Attachment #249989 -
Flags: ui-review?(beltzner)
Attachment #249989 -
Flags: ui-review+
Attachment #249989 -
Flags: approval1.8.1.2?
Assignee | ||
Comment 6•18 years ago
|
||
A reminder: please check this in as soon as it's approved (I won't be able to do so). And FWIW: this is just half the patch from bug 348031 which already got approval1.8.1.1+.
Whiteboard: need r=mano → [checkin needed (1.8 branch)]
Comment 7•18 years ago
|
||
Comment on attachment 249989 [details] [diff] [review]
branch patch
Approved for 1.8 branch, a=jay for drivers.
mconnor: Could you check this in for Simon? Or find someone who can? Thanks!
Attachment #249989 -
Flags: approval1.8.1.2? → approval1.8.1.2+
Comment 8•18 years ago
|
||
browser/base/content/browser.js 1.479.2.216
I take it, this doesn't need a trunk checkin, so marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1.2
Resolution: --- → FIXED
Whiteboard: [checkin needed (1.8 branch)]
Comment 9•18 years ago
|
||
Verified fixed for 1.8.1.2 after tests with Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.2pre) Gecko/2007012803 BonEcho/2.0.0.2pre on Windows and Linux
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1.2 → verified1.8.1.2
Assignee | ||
Comment 10•18 years ago
|
||
(In reply to comment #9)
> Verified fixed
It seems that this bug hasn't been fixed at all: see bug 356581 comment #5.
I guess this is because the focus is immediately set back to the content area in tabbrowser::updateCurrentBrowser right after we focus the address bar. Delaying |gURLBar.focus();| slightly further - e.g. until after |gBrowser.removeCurrentTab();| should do the trick.
OTOH this still looks too fragile, so we might want a completely different fix. Leaving that to bug 356581 though...
You need to log in
before you can comment on or make changes to this bug.
Description
•