Closed Bug 365580 Opened 18 years ago Closed 9 years ago

roaming doesn't work properly if you try to roam a large enough number of files

Categories

(Core Graveyard :: Profile: Roaming, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: timeless, Unassigned)

Details

"@mozilla.org/embedcomp/dialogparam;1" doesn't scale and can't be used for roaming I'm testing roaming and managed to accumulate a fairly large number of "roamed" files. unfortunately, this doesn't work. embedcomponents!nsDialogParamBlock::InBounds(int inIndex = 21, int inMax = 16) [mozilla\embedding\components\windowwatcher\src\nsdialogparamblock.h @ 64] embedcomponents!nsDialogParamBlock::SetString(int inIndex = 21, unsigned short * inString = 0x0012b674 "prefs.js")+0x30 [mozilla\embedding\components\windowwatcher\src\nsdialogparamblock.cpp @ 99] WARNING: Stack unwind information not available. Following frames may be wrong. sroaming!NSGetModule+0x5831 the code should instead pass an nsIArray or nsIPropert* or similar creature. enum {kNumInts = 8, kNumStrings = 16}; nsresult InBounds(PRInt32 inIndex, PRInt32 inMax) { return inIndex >= 0 && inIndex < inMax ? NS_OK : NS_ERROR_ILLEGAL_VALUE;
This also reflects as a js exception later: Exception ``[Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIDialogParamBlock.GetString]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: chrome://sroaming/content/transfer/progressDialog.js :: GetParams :: line 158" data: no]'' thrown from function GetParams() in <chrome://sroaming/content/transfer/progressDialog.js> line 158. Stopped for thrown exception. #0: function GetParams() in <chrome://sroaming/content/transfer/progressDialog.js> line 158 156: for (var i = 0; i < count; i++) 157: { 158: var filename = params.GetString(i + 4); // filenames start at item 4
I remember an old bug about it, and IIRC Pete Zha created a patch for it, but upping the limit or whatever (wasn't very clean), I don't remember and I can't find the bug anymore.
This bug is filed in a bugzilla component related to pre-Firefox code which no longer exists. I believe it is no longer relevant and I am therefore closing it INCOMPLETE. If you believe that this bug is still valid and needs to be fixed, please reopen it and move it to the Toolkit:Startup and Profile System product/component.
No longer blocks: 1243899
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INCOMPLETE
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.