Closed
Bug 366285
Opened 18 years ago
Closed 18 years ago
Need a common class of the fontconfig management for Linux and BeOS
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(1 file, 4 obsolete files)
|
(deleted),
patch
|
vlad
:
review+
|
Details | Diff | Splinter Review |
We have a very many duplicated code in gfxPlatformGtk and gfxBeOSPlatform. The duplicated code is accessing to fontconfig. So, we can create the common super class for gfxPlatformGtk and gfxBeOSPlatform.
|
Assignee | |
Comment 1•18 years ago
|
||
I have a worry. We may use other class like Mac(gfxQuartzFontCache). But we don't have another option of fontconfig in Linux...
Attachment #250819 -
Flags: review?(vladimir)
|
|
Assignee | |
Comment 2•18 years ago
|
||
updating the license block.
Attachment #250819 -
Attachment is obsolete: true
Attachment #250822 -
Flags: review?(vladimir)
Attachment #250819 -
Flags: review?(vladimir)
|
|
Assignee | |
Comment 3•18 years ago
|
||
maybe, this is correct...
Attachment #250822 -
Attachment is obsolete: true
Attachment #250827 -
Flags: review?(vladimir)
Attachment #250822 -
Flags: review?(vladimir)
|
|
Assignee | |
Updated•18 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•18 years ago
|
||
The alternative patch. This is better for portability.
Attachment #250827 -
Attachment is obsolete: true
Attachment #251623 -
Flags: review?(vladimir)
Attachment #250827 -
Flags: review?(vladimir)
|
|
Assignee | |
Comment 5•18 years ago
|
||
Attachment #251623 -
Attachment is obsolete: true
Attachment #251624 -
Flags: review?(vladimir)
Attachment #251623 -
Flags: review?(vladimir)
|
|
Assignee | |
Updated•18 years ago
|
Summary: Need gfxPlatformFontconfig for Linux and BeOS → Need a common class of the fontconfig management for Linux and BeOS
|
|
Assignee | |
Comment 6•18 years ago
|
||
Vlad:
Would you review this? This patch only moves the common code to the new class.
Attachment #251624 -
Flags: review?(vladimir) → review+
|
|
Assignee | |
Comment 7•18 years ago
|
||
checked-in, thanks.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•