Closed Bug 366367 Opened 18 years ago Closed 18 years ago

SeaMonkey link on mailnews start page is incorrect in suiterunner

Categories

(SeaMonkey :: MailNews: Message Display, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: standard8, Assigned: bugzilla)

References

Details

Attachments

(1 file, 1 obsolete file)

Start up mailnews in suiterunner. On the "Welcome to SeaMonkey Mail & Newsgroups" banner, SeaMonkey links to http://www.mozilla.org/ - it should link to http://www.mozilla.org/projects/seamonkey/

The problem is that the mailnews start page (http://lxr.mozilla.org/seamonkey/source/mailnews/base/resources/content/start.xhtml) 
uses vendorURL (http://lxr.mozilla.org/seamonkey/search?string=vendorURL) which is defined in toolkit's region.dtd. xpfe SeaMonkey defines this in region.properties.

I guess what we should do is define vendorURL as a pref pointing to brand.properties, and use the urlformatter in a similar style to the other urls in the start.xhtml page to set the title correctly.

I don't think this will cause any problems - from what I can tell the vendorURL in toolkit is not required or doesn't have any significant affect.
Status: NEW → ASSIGNED
Assignee: mail → aqualon
Status: ASSIGNED → NEW
As a note, the localized pref to use through urlformatter should probably be app.vendorURL - and we probably should file a bug for http://lxr.mozilla.org/seamonkey/source/toolkit/content/about.xhtml#63 to use the same pref.
Attached patch define vendorURL as pref and use URLFormatterService (obsolete) (deleted) β€” β€” Splinter Review
Attachment #251231 - Flags: superreview?(neil)
Attachment #251231 - Flags: review?(kairo)
Comment on attachment 251231 [details] [diff] [review]
define vendorURL as pref and use URLFormatterService

>Index: suite/locales/en-US/chrome/branding/brand.properties
>===================================================================
> app.releaseNotesURL=http://www.mozilla.org/projects/seamonkey/releases/seamonkey%VERSION%/
> keyword.moreInfoURL=http://www.mozilla.org/docs/end-user/internet-keywords.html
>+app.vendorURL=http://www.mozilla.org/projects/seamonkey/

Nit: Move the new entry one line up so the two app.* ones are next to each other.

r=me
Attachment #251231 - Flags: review?(kairo) → review+
Blocks: 366814
Attachment #251231 - Flags: superreview?(neil) → superreview+
Comment on attachment 251231 [details] [diff] [review]
define vendorURL as pref and use URLFormatterService

Oh, don't forget to update xpfe's browser-prefs.js too.
Attached patch Previous patch including review comments (deleted) β€” β€” Splinter Review
Attachment #251231 - Attachment is obsolete: true
Attachment #252177 - Flags: superreview+
Attachment #252177 - Flags: review+
Landed on trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: