Closed Bug 366936 Opened 18 years ago Closed 18 years ago

Run WHATWG/html5lib tests on HTML parser

Categories

(Core :: DOM: HTML Parser, defect)

Product:
Core
Component:
DOM: HTML Parser
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9alpha3

People

(Reporter: sayrer, Assigned: sayrer)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files, 10 obsolete files)

reusable parser harness
(deleted), patch
Details | Diff | Splinter Review
integrate with build
(deleted), patch
mrbkap
: review+
Details | Diff | Splinter Review
Before we can move on bug 361449, we need better test coverage for the HTML parser, and it needs to be running automatically. The http://html5lib.googlecode.com/ project has a decent test suite started, so we should use their cases. These can be run in the browser using mochitest, and then on the command line once bug 361449 lands.
a few syntax errors in the last version
Attachment #251403 - Attachment is obsolete: true
Attached file test HTML file (obsolete) (deleted) —
Attachment #251415 - Attachment mime type: application/x-javascript → text/plain
Attached file html5-tree-parser.js (obsolete) (deleted) —
Attachment #251415 - Attachment is obsolete: true
Attached file test html (obsolete) (deleted) —
Attachment #251416 - Attachment is obsolete: true
Attached file html5-tree-parser.js (obsolete) (deleted) —
Attachment #251457 - Attachment is obsolete: true
Attached file Passing 76, Failing 100 (obsolete) (deleted) —
Looks like many of the failures are due to doctype capitalization and attribute order (todo). The doctype capitalization should be an easy patch.
Attachment #251458 - Attachment is obsolete: true
Patch in bug 366993 makes Passing 97, Failing 79
OS: Linux → All
Hardware: PC → All
Attached file html5-tree-parser.js -- passing 103, failing 73 (obsolete) (deleted) —
(with patch for bug 366993)
Attachment #251471 - Attachment is obsolete: true
A little error in the test harness gets us three more (with patch for bug 366993)
Attachment #251490 - Attachment is obsolete: true
Attachment #251505 - Attachment mime type: application/x-javascript → text/plain
Blocks: 370946
Attached patch passing 113, failing 68 (obsolete) (deleted) — — Splinter Review
Attachment #251472 - Attachment is obsolete: true
Attachment #251505 - Attachment is obsolete: true
Attached patch reusable parser harness (deleted) — — Splinter Review
Attachment #256813 - Attachment is obsolete: true
Attachment #257190 - Attachment is patch: true
Attachment #257190 - Attachment mime type: text/x-patch → text/plain
Attached patch integrate with build (deleted) — — Splinter Review
Attachment #257196 - Flags: review?(mrbkap)
Comment on attachment 257196 [details] [diff] [review] integrate with build Cool.
Attachment #257196 - Flags: review?(mrbkap) → review+
RCS file: /cvsroot/mozilla/parser/htmlparser/tests/mochitest/html5_tree_construction_exceptions.js,v done Checking in html5_tree_construction_exceptions.js; /cvsroot/mozilla/parser/htmlparser/tests/mochitest/html5_tree_construction_exceptions.js,v <-- html5_tree_construction_exceptions.js initial revision: 1.1 done RCS file: /cvsroot/mozilla/parser/htmlparser/tests/mochitest/html5lib_license.txt,v done Checking in html5lib_license.txt; /cvsroot/mozilla/parser/htmlparser/tests/mochitest/html5lib_license.txt,v <-- html5lib_license.txt initial revision: 1.1 done RCS file: /cvsroot/mozilla/parser/htmlparser/tests/mochitest/html5lib_tree_dat1.txt,v done Checking in html5lib_tree_dat1.txt; /cvsroot/mozilla/parser/htmlparser/tests/mochitest/html5lib_tree_dat1.txt,v <-- html5lib_tree_dat1.txt initial revision: 1.1 done RCS file: /cvsroot/mozilla/parser/htmlparser/tests/mochitest/html5lib_tree_dat2.txt,v done Checking in html5lib_tree_dat2.txt; /cvsroot/mozilla/parser/htmlparser/tests/mochitest/html5lib_tree_dat2.txt,v <-- html5lib_tree_dat2.txt initial revision: 1.1 done RCS file: /cvsroot/mozilla/parser/htmlparser/tests/mochitest/html5lib_tree_dat3.txt,v done Checking in html5lib_tree_dat3.txt; /cvsroot/mozilla/parser/htmlparser/tests/mochitest/html5lib_tree_dat3.txt,v <-- html5lib_tree_dat3.txt initial revision: 1.1 done RCS file: /cvsroot/mozilla/parser/htmlparser/tests/mochitest/parser_datreader.js,v done Checking in parser_datreader.js; /cvsroot/mozilla/parser/htmlparser/tests/mochitest/parser_datreader.js,v <-- parser_datreader.js initial revision: 1.1 done RCS file: /cvsroot/mozilla/parser/htmlparser/tests/mochitest/parser_web_testrunner.js,v done Checking in parser_web_testrunner.js; /cvsroot/mozilla/parser/htmlparser/tests/mochitest/parser_web_testrunner.js,v <-- parser_web_testrunner.js initial revision: 1.1 done RCS file: /cvsroot/mozilla/parser/htmlparser/tests/mochitest/test_html5_tree_construction.html,v done Checking in test_html5_tree_construction.html; /cvsroot/mozilla/parser/htmlparser/tests/mochitest/test_html5_tree_construction.html,v <-- test_html5_tree_construction.html initial revision: 1.1 done Checking in Makefile.in; /cvsroot/mozilla/parser/htmlparser/tests/mochitest/Makefile.in,v <-- Makefile.in new revision: 1.3; previous revision: 1.2 done
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha3
I had to comment these out because JS is misbehaving, making our suite unable to run this.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Blocks: html5-parsing
relanded these without incident
Status: REOPENED → RESOLVED
Closed: 18 years ago → 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: