Closed
Bug 367015
Opened 18 years ago
Closed 18 years ago
Crash [@ nsBidiPresUtils::RepositionInlineFrames]
Categories
(Core :: Layout: Text and Fonts, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: uriber)
References
Details
(Keywords: crash, regression, testcase)
Crash Data
Attachments
(2 files)
|
(deleted),
text/html
|
Details | |
|
(deleted),
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Loading this testcase makes Firefox trunk crash [@ nsBidiPresUtils::RepositionInlineFrames].
This regressed between 2007-01-11 and 2007-01-14. Could it have been caused by the patch in bug 364839?
|
Assignee | |
Comment 1•18 years ago
|
||
> This regressed between 2007-01-11 and 2007-01-14. Could it have been caused by
> the patch in bug 364839?
>
Yes, it probably was. I'll look at it later today.
|
|
Assignee | |
Comment 2•18 years ago
|
||
Deal with empty line frames (although I'm not sure why there should be an empty line frame in this case, or ever).
Assignee: nobody → uriber
Status: NEW → ASSIGNED
Attachment #251543 -
Flags: superreview?(bzbarsky)
Attachment #251543 -
Flags: review?(bzbarsky)
|
||
Comment 3•18 years ago
|
||
Comment on attachment 251543 [details] [diff] [review]
patch
Looks reasonable. r+sr=bzbarsky.
The reason there's an empty line frame is that :first-line is a mess and we get an empty line frame if the first child is a block... ;)
Attachment #251543 -
Flags: superreview?(bzbarsky)
Attachment #251543 -
Flags: superreview+
Attachment #251543 -
Flags: review?(bzbarsky)
Attachment #251543 -
Flags: review+
|
|
Assignee | |
Comment 4•18 years ago
|
||
Checked in:
Checking in mozilla/layout/base/nsBidiPresUtils.cpp;
/cvsroot/mozilla/layout/base/nsBidiPresUtils.cpp,v <-- nsBidiPresUtils.cpp
new revision: 1.90; previous revision: 1.89
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: layout.bidi → layout.fonts-and-text
|
||
Updated•13 years ago
|
Crash Signature: [@ nsBidiPresUtils::RepositionInlineFrames]
You need to log in
before you can comment on or make changes to this bug.
Description
•