Closed Bug 367489 Opened 18 years ago Closed 18 years ago

[FIX]"###!!! ASSERTION: Nested first-line frames? BOGUS"

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: jruderman, Assigned: bzbarsky)

References

Details

(Keywords: assertion, regression, testcase)

Attachments

(3 files)

Attached file testcase (deleted) —
Loading the testcase triggers: ###!!! ASSERTION: Nested first-line frames? BOGUS: '!aReflowState.mLineLayout->GetInFirstLine()', file /Users/admin/trunk/mozilla/layout/generic/nsInlineFrame.cpp, line 918 I think this is a recent regression, because I'm seeing it a lot today and don't remember seeing it before.
Attached patch Pass around the right frame (deleted) — Splinter Review
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #253994 - Flags: superreview?(roc)
Attachment #253994 - Flags: review?(roc)
We were constructing a first-line frame for the <b>, which is just bogus as the assert says. ;)
OS: Mac OS X → All
Hardware: Macintosh → All
Summary: "###!!! ASSERTION: Nested first-line frames? BOGUS" → [FIX]"###!!! ASSERTION: Nested first-line frames? BOGUS"
Target Milestone: --- → mozilla1.9alpha
Attachment #253994 - Flags: superreview?(roc)
Attachment #253994 - Flags: superreview+
Attachment #253994 - Flags: review?(roc)
Attachment #253994 - Flags: review+
Fixed
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Depends on: 368573
Flags: in-testsuite?
The word "foo" loses its boldness when the timer fires. I don't think it should. Should I file a separate bug?
No, I think that's this bug. We're putting things in the wrong framelist.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch This fixes that issue (deleted) — Splinter Review
Attachment #254005 - Flags: superreview?(roc)
Attachment #254005 - Flags: review?(roc)
Attachment #254005 - Flags: superreview?(roc)
Attachment #254005 - Flags: superreview+
Attachment #254005 - Flags: review?(roc)
Attachment #254005 - Flags: review+
Checked that in too.
Status: REOPENED → RESOLVED
Closed: 18 years ago18 years ago
Resolution: --- → FIXED
Reftest checked in.
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: