Comment on attachment 252175 [details] [diff] [review] implement normalize >Index: nsLocalFileOSX.cpp >=================================================================== >+ PRBool success; >+ success = ::CFURLGetFileSystemRepresentation(mBaseRef, true, path, PATH_MAX); nit: use BOOL here. >+ if (!success) >+ return NS_ERROR_FAILURE; >+ >+ char resolved_path[PATH_MAX] = ""; >+ char *resolved_path_ptr = nsnull; >+ resolved_path_ptr = realpath((char*)path, resolved_path); >+ >+ // if there is an error, the return is null. >+ if (!resolved_path_ptr) >+ return NS_ERROR_FAILURE; >+ >+ // Need to know whether we're a directory to create a new CFURLRef >+ PRBool isDirectory; >+ nsresult rv = IsDirectory(&isDirectory); >+ if (NS_FAILED(rv)) >+ return rv; >+ nit: use NS_ENSURE_SUCCESS. r=mano otherwise.

re: nit 1, I used Boolean, not BOOL. I also changed the result code if realpath fails, to emulate the unix version.

Checking in io/nsLocalFileOSX.cpp; /cvsroot/mozilla/xpcom/io/nsLocalFileOSX.cpp,v <-- nsLocalFileOSX.cpp new revision: 1.48; previous revision: 1.47 done Checking in tests/nsIFileTest.cpp; /cvsroot/mozilla/xpcom/tests/nsIFileTest.cpp,v <-- nsIFileTest.cpp new revision: 1.32; previous revision: 1.31 done