Closed Bug 368362 Opened 18 years ago Closed 16 years ago

vista integration: fix nsPostupdateWindow.js / nsUpdateService.js.in / thunderbirdHelper.exe

Categories

(Thunderbird :: General, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: moco, Unassigned)

Details

for thunderbird, there are three places we need to worry about: 1) in nsPostUpdateWindow.js, we'll need to fix checkRegistry() [not yet landed] for tbird. for firefox, we look for the -requestPending (part of robert's dde work for firefox) on the FirefoxHTML key. +function checkRegistry() +{ + // XXX todo + // this is firefox specific + // figure out what to do about tbird and sunbird, etc + LOG("checkRegistry"); + + var result = false; + try { + var key = new RegKey(); + key.open(RegKey.prototype.ROOT_KEY_CLASSES_ROOT, "FirefoxHTML\\shell\\open\\command", key.ACCESS_READ); + var commandKey = key.readStringValue(""); + LOG("commandKey = " + commandKey); + // if "-requestPending" is not found, we need to do the cleanup + result = (commandKey.indexOf("-requestPending") == -1); 2) mozapps/update/src/nsUpdateService.js.in +#ifdef MOZ_PHOENIX + // for now, this is firefox only. + // we need to fix both nsPostUpdateWin.js and + // the uninstaller to work for thunderbird and sunbird + // // Perform platform-specific post-update processing. if (POST_UPDATE_CONTRACTID in Components.classes) { Components.classes[POST_UPDATE_CONTRACTID]. createInstance(Components.interfaces.nsIRunnable).run(); } +#endif once we fix nsPostUpdateWin.js to be tbird friendly we can remove that ifdef. 3) we'd need a thunderbirdHelper.exe (see #368353, it's an app based on our NSIS uninstaller that does all the log copying and registry clean up that nsPostUpdateWin.js used to do.) I'll log a spin on bug on these issues. note, we need thunderbirdHelper.exe for windows xp/2k too.
Assignee: mscott → nobody
Fixed this on trunk so Thunderbird no longer requires nsPostupdateWindow.js and uses helper.exe
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.