Closed
Bug 369642
Opened 18 years ago
Closed 18 years ago
L10n repackaging fails on uninst.exe
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: u60234, Assigned: robert.strong.bugs)
References
Details
(Keywords: fixed1.8.1.2)
Attachments
(1 file)
(deleted),
patch
|
preed
:
review+
moco
:
review+
jay
:
approval1.8.1.2+
|
Details | Diff | Splinter Review |
Repackaging of Windows l10n builds on 1.8 branch is currently broken because it tries to copy a non-existent file, uninst.exe. From the latest tinderbox log for Mozilla1.8-l10n-sv-SE:
cp ../installer/windows/l10ngen/uninst.exe l10n-stage/localized/uninstall
cp: cannot stat `../installer/windows/l10ngen/uninst.exe': No such file or directory
It looks like browser/locales/Makefile.in on 1.8 branch needs to be made aware of the renaming of uninst.exe to helper.exe per bug 368353.
Trunk repackaging works OK.
Assignee | ||
Comment 1•18 years ago
|
||
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #254333 -
Flags: review?(sspitzer)
Attachment #254333 -
Flags: approval1.8.1.2?
Assignee | ||
Updated•18 years ago
|
Attachment #254333 -
Attachment description: patch → patch - branch only
Assignee | ||
Updated•18 years ago
|
Attachment #254333 -
Flags: review?(sspitzer) → review?(preed)
Comment 2•18 years ago
|
||
Comment on attachment 254333 [details] [diff] [review]
patch - branch only
Approved for 1.8 branch, a=jay (as soon as preed gives the s= we should get this landed).
Attachment #254333 -
Flags: approval1.8.1.2? → approval1.8.1.2+
Comment 3•18 years ago
|
||
Comment on attachment 254333 [details] [diff] [review]
patch - branch only
You're a gentlemen and a scholar.
Attachment #254333 -
Flags: review?(preed) → review+
Comment 4•18 years ago
|
||
Comment on attachment 254333 [details] [diff] [review]
patch - branch only
rob, should we add uninst.exe to the
removed-files.in?
Attachment #254333 -
Flags: review+
Assignee | ||
Comment 5•18 years ago
|
||
(In reply to comment #4)
> (From update of attachment 254333 [details] [diff] [review])
> rob, should we add uninst.exe to the
> removed-files.in?
We did. :)
Assignee | ||
Comment 6•18 years ago
|
||
Fixed on MOZILLA_1_8_BRANCH
Updated•6 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•