Closed
Bug 369690
Opened 18 years ago
Closed 18 years ago
nsPresContext::mImageLoaders uses wrong key
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: sharparrow1)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
I'm all in favor of the change to nsInterfaceHashtable made in bug 177805, but we don't want nsUint32HashKey here. The key is an nsIFrame*, so we want nsVoidPtrHashKey, no?
Flags: blocking1.9?
|
Assignee | |
Comment 1•18 years ago
|
||
Ah, I didn't realize that change got mixed in with that patch. Would you mind looking it over to make sure that everything else is right? About the nsVoidPtrHashKey: I actually didn't know that existed. See http://lxr.mozilla.org/seamonkey/source/xpcom/glue/nsHashKeys.h#54 for the (incomplete) list of hash keys. That's definitely correct; I'll post a patch soon.
|
Reporter | |
Comment 2•18 years ago
|
||
Yeah, the rest of it looks fine.
|
|
Assignee | |
Comment 3•18 years ago
|
||
Attachment #254505 -
Flags: review?(bzbarsky)
|
|
Reporter | |
Comment 4•18 years ago
|
||
Comment on attachment 254505 [details] [diff] [review] Patch t+sr=bzbarsky. Feel free to add this class to the list in that comment you mentioned, by the way!
Attachment #254505 -
Flags: superreview+
Attachment #254505 -
Flags: review?(bzbarsky)
Attachment #254505 -
Flags: review+
|
|
Assignee | |
Comment 5•18 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•18 years ago
|
Flags: in-testsuite-
|
|
Reporter | |
Updated•18 years ago
|
Flags: blocking1.9?
You need to log in
before you can comment on or make changes to this bug.
Description
•