In bug 360133, bookmarks in Places are getting unique identifiers. The microsummaries code needs to be updated to use those identifiers instead of URIs to refer to the bookmarks it summarizes.

Among other things, this means fixing references in nsMicrosummaryService.js to bookmarkID.spec so that they refer to the PRInt64 equivalent (probably just bookmarkID).

See bug 370216 comment 1

Comment on attachment 258160 [details] [diff] [review] patch >- _getField: function MSS__getField(bookmarkID, fieldName) { >- var pageURI = bookmarkID.QueryInterface(Ci.nsIURI); >+ _getField: function MSS__getField(aPlaceURI, aFieldName) { >+ aPlaceURI.QueryInterface(Ci.nsIURI); Nit: if I recall correctly, mconnor has said we are standardizing on not having "a" prefixes on method arguments, so these should be prefix-less here and elsewhere. Otherwise, this looks fine. I haven't been able to test, however, as Places is horked on my build.

Myk, where did mconnor say (or write) about not using Hungarian notation? (I'm sure you're going to get a bunch of people who like it, and a bunch of people who don't.)

(In reply to comment #5) > Myk, where did mconnor say (or write) about not using Hungarian notation? I don't recall, but I'll ping him shortly to confirm. Perhaps I misunderstood or misattributed that statement to mconnor when it was actually uttered by someone less authoritative. > (I'm sure you're going to get a bunch of people who like it, and a bunch of > people who don't.) Right. We'll never make everyone happy no matter which way we go on this.

(In reply to comment #6) > (In reply to comment #5) > > Myk, where did mconnor say (or write) about not using Hungarian notation? > > I don't recall, but I'll ping him shortly to confirm. Perhaps I misunderstood > or misattributed that statement to mconnor when it was actually uttered by > someone less authoritative. Correction: no-a was Ben's position; yes-a was mconnor's, and we're going with yes-a. So the review stands with the nit rescinded.

mozilla/browser/components/microsummaries/src/nsMicrosummaryService.js 1.58 mozilla/browser/components/places/content/bookmarkProperties.js 1.35 mozilla/browser/components/places/content/controller.js 1.136 mozilla/browser/components/places/content/toolbar.xml 1.76