Closed
Bug 370549
Opened 18 years ago
Closed 18 years ago
extend nsITheme to support native focus drawing
Categories
(Core :: Layout: Form Controls, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jaas, Assigned: jaas)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
dbaron
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
Layout draws focus indicators (outlines) on most themed widgets whether or not they draw their own indicators. Native widget implementations should be able to specify whether or not they draw their own focus indicators via nsITheme.
Attachment #255260 -
Flags: review?(dbaron)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 255260 [details] [diff] [review]
fix v1.0
r=dbaron. You might want to check that roc's ok with this.
Attachment #255260 -
Flags: review?(dbaron) → review+
Attachment #255260 -
Flags: superreview?(roc)
|
||
Comment 3•18 years ago
|
||
Is using a narrow type such as PRUint8 for aWidgetType worth it? It can cost in terms of widening (in the callee) and (when calling) narrowing loads and stores. The parameter seems to cry for an enum type, but could be PRUintn.
/be
We should probably look into that, but that param is used all over the place as PRUint8. I think it'd be best to deal with that separately instead of in this patch.
This is fine with me. We can actually use this for GTK2 as well, but that's not your problem.
Attachment #255260 -
Flags: superreview?(roc) → superreview+
landed on trunk
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•